Implement sync error auto-show logic and add unit tests for error visibility conditions

Author: oleonov

app/src/main/java/cash/p/terminal/modules/balance/token/TokenBalanceScreen.kt

@@ -79,6 +79,7 @@ import cash.p.terminal.ui.compose.components.BadgeText
 import cash.p.terminal.ui.compose.components.CoinIconWithSyncProgress
 import cash.p.terminal.ui.compose.components.ListEmptyView
 import cash.p.terminal.ui_compose.CoinFragmentInput
+import cash.p.terminal.ui_compose.ScreenSecurityState
 import cash.p.terminal.ui_compose.components.AppBar
 import cash.p.terminal.ui_compose.components.ButtonPrimaryCircle
 import cash.p.terminal.ui_compose.components.ButtonPrimaryDefault
@@ -124,8 +125,9 @@ fun TokenBalanceScreen(
     val loading = uiState.balanceViewItem?.syncingProgress?.progress != null
 
     LaunchedEffect(failedIconVisible) {
-        if (failedIconVisible) {
-            onSyncErrorClicked(uiState.balanceViewItem, viewModel, navController)
+        val viewItem = uiState.balanceViewItem
+        if (viewItem != null && shouldAutoShowSyncError(failedIconVisible, ScreenSecurityState.isAppLocked)) {
+            onSyncErrorClicked(viewItem, viewModel, navController)
         }
     }
 
@@ -654,6 +656,11 @@ private fun LockedBalanceCell(
     }
 }
 
+// Never auto-open the wallet sync-error sheet while the app is locked: it lives in its
+// own Window and would leak wallet UI above the calculator/PIN disguise (deanonymization).
+internal fun shouldAutoShowSyncError(failedIconVisible: Boolean, appLocked: Boolean): Boolean =
+    failedIconVisible && !appLocked
+
 private fun onSyncErrorClicked(
     viewItem: BalanceViewItem,
     viewModel: TokenBalanceViewModel,

app/src/main/java/cash/p/terminal/modules/main/MainActivity.kt

@@ -69,6 +69,11 @@ open class MainActivity : BaseActivity() {
             showPinLockScreen = false
             pinLockComposeView?.visibility = GONE
             applyLockWindowFlags(isLocked = false, calculatorMode = true)
+        } else if (pinComponent.isLockedFlow.value) {
+            // Locked on return: a dialog left open in the background lives in its own
+            // Window and would surface above the calculator/PIN disguise. The collect in
+            // observeLockState reacts asynchronously, so close synchronously here too.
+            closeWindowsAboveLockScreen()
         }
         validate()
     }

app/src/test/java/cash/p/terminal/modules/balance/token/SyncErrorAutoShowGuardTest.kt

@@ -0,0 +1,23 @@
+package cash.p.terminal.modules.balance.token
+
+import org.junit.Assert.assertFalse
+import org.junit.Assert.assertTrue
+import org.junit.Test
+
+class SyncErrorAutoShowGuardTest {
+
+    @Test
+    fun shouldAutoShowSyncError_failedAndUnlocked_returnsTrue() {
+        assertTrue(shouldAutoShowSyncError(failedIconVisible = true, appLocked = false))
+    }
+
+    @Test
+    fun shouldAutoShowSyncError_failedAndLocked_returnsFalse() {
+        assertFalse(shouldAutoShowSyncError(failedIconVisible = true, appLocked = true))
+    }
+
+    @Test
+    fun shouldAutoShowSyncError_notFailedAndUnlocked_returnsFalse() {
+        assertFalse(shouldAutoShowSyncError(failedIconVisible = false, appLocked = false))
+    }
+}