Removed checking card number for signing to avoid problems with ssigning by not primary card

Author: oleonov

feature-tangem/src/main/java/cash/p/terminal/tangem/domain/usecase/SignHashesTransactionUseCase.kt

@@ -7,13 +7,12 @@ import com.tangem.crypto.hdWallet.DerivationPath
 class SignHashesTransactionUseCase(private val tangemSdkManager: TangemSdkManager) {
 
     suspend operator fun invoke(
-        cardId: String?,
         hashes: Array<ByteArray>,
         walletPublicKey: ByteArray,
         derivationPath: DerivationPath?,
         message: Message? = null
     ) = tangemSdkManager.sign(
-        cardId = cardId,
+        cardId = null,
         hashes = hashes,
         walletPublicKey = walletPublicKey,
         derivationPath = derivationPath,

feature-tangem/src/main/java/cash/p/terminal/tangem/domain/usecase/SignOneHashTransactionUseCase.kt

@@ -7,13 +7,12 @@ import com.tangem.crypto.hdWallet.DerivationPath
 class SignOneHashTransactionUseCase(private val tangemSdkManager: TangemSdkManager) {
 
     suspend operator fun invoke(
-        cardId: String?,
         hash: ByteArray,
         walletPublicKey: ByteArray,
         derivationPath: DerivationPath?,
         message: Message? = null
     ) = tangemSdkManager.sign(
-            cardId = cardId,
+            cardId = null,
             hash = hash,
             walletPublicKey = walletPublicKey,
             derivationPath = derivationPath,

feature-tangem/src/main/java/cash/p/terminal/tangem/signer/HardwareWalletBinanceChainSigner.kt

@@ -31,7 +31,6 @@ class HardwareWalletBinanceChainSigner(
         return runBlocking {
             val signBytesResponse =
                 signOneHashTransactionUseCase(
-                    cardId = cardId,
                     hash = message,
                     walletPublicKey = hardwarePublicKey.publicKey,
                     derivationPath = DerivationPath(hardwarePublicKey.derivationPath)

feature-tangem/src/main/java/cash/p/terminal/tangem/signer/HardwareWalletEcdaSigner.kt

@@ -80,7 +80,6 @@ class HardwareWalletEcdaSigner(
             "${hardwarePublicKey.derivationPath}/$changeSegment/$addressIndexSegment"
         Log.d("HardwareWalletSigner", "sigScriptEcdsaData $fullDerivationPathString")
         val signResponse: CompletionResult<SignResponse> = signHashesTransactionUseCase(
-            cardId = cardId,
             hashes = arrayOf(hashToSign),
             walletPublicKey = hardwarePublicKey.publicKey,
             derivationPath = DerivationPath(fullDerivationPathString)
@@ -178,7 +177,6 @@ class HardwareWalletEcdaSigner(
             val fullDerivationPathForAddress = DerivationPath(fullDerivationPathString)
 
             val signResponse: CompletionResult<SignResponse> = signHashesTransactionUseCase(
-                cardId = cardId,
                 hashes = dataHashes.toTypedArray(),
                 walletPublicKey = hardwarePublicKey.publicKey,
                 derivationPath = fullDerivationPathForAddress

feature-tangem/src/main/java/cash/p/terminal/tangem/signer/HardwareWalletEvmSigner.kt

@@ -116,7 +116,7 @@ class HardwareWalletEvmSigner(
         isLegacy: Boolean
     ): Signature {
         val signBytesResponse =
-            signOneHashTransactionUseCase(cardId, hash, walletPublicKey, DerivationPath(publicKey.derivationPath))
+            signOneHashTransactionUseCase(hash, walletPublicKey, DerivationPath(publicKey.derivationPath))
         when (signBytesResponse) {
             is CompletionResult.Success -> {
                 val byteSignature = signBytesResponse.data.signature

feature-tangem/src/main/java/cash/p/terminal/tangem/signer/HardwareWalletSchnorrSigner.kt

@@ -85,7 +85,6 @@ class HardwareWalletSchnorrSigner(
         val walletPublicKey =
             hardwarePublicKey.publicKey.copyOfRange(1, hardwarePublicKey.publicKey.size)
         val signResponse: CompletionResult<SignResponse> = signHashesTransactionUseCase(
-            cardId = cardId,
             hashes = dataToSign.toTypedArray(),
             walletPublicKey = walletPublicKey,
             derivationPath = DerivationPath(fullDerivationPathString)
@@ -127,7 +126,6 @@ class HardwareWalletSchnorrSigner(
         val walletPublicKey =
             hardwarePublicKey.publicKey.copyOfRange(1, hardwarePublicKey.publicKey.size)
         val signResponse: CompletionResult<SignResponse> = signHashesTransactionUseCase(
-            cardId = cardId,
             hashes = arrayOf(signatureHash),
             walletPublicKey = walletPublicKey,
             derivationPath = DerivationPath(fullDerivationPathString)

feature-tangem/src/main/java/cash/p/terminal/tangem/signer/HardwareWalletSolanaAccountSigner.kt

@@ -22,7 +22,6 @@ class HardwareWalletSolanaAccountSigner(
         return runBlocking {
             val signBytesResponse =
                 signOneHashTransactionUseCase(
-                    cardId = cardId,
                     hash = serializedMessage,
                     walletPublicKey = hardwarePublicKey.publicKey,
                     derivationPath = DerivationPath(hardwarePublicKey.derivationPath)

feature-tangem/src/main/java/cash/p/terminal/tangem/signer/HardwareWalletTronSigner.kt

@@ -36,7 +36,6 @@ class HardwareWalletTronSigner(
         return runBlocking {
             val signBytesResponse =
                 signOneHashTransactionUseCase(
-                    cardId = cardId,
                     hash = rawTransactionHash,
                     walletPublicKey = hardwarePublicKey.publicKey,
                     derivationPath = DerivationPath(hardwarePublicKey.derivationPath)

feature-tangem/src/main/java/cash/p/terminal/tangem/signer/TonPrivateKeyEd25519.kt

@@ -38,7 +38,6 @@ class TonPrivateKeyEd25519(
         return runBlocking {
             val signBytesResponse =
                 signOneHashTransactionUseCase(
-                    cardId = cardId,
                     hash = message,
                     walletPublicKey = hardwarePublicKey.publicKey,
                     derivationPath = DerivationPath(hardwarePublicKey.derivationPath)