Cyclic focus to next/previous sibling tab #3725

Author: piroor

webextensions/background/handle-misc.js

@@ -259,13 +259,17 @@ async function onShortcutCommand(command) {
     case 'focusPreviousSibling':
       TabsInternalOperation.activateTab(
         activeTab.$TST.previousSiblingTab ||
-          activeTab.$TST.parent && activeTab.$TST.parent.$TST.lastChild
+          (activeTab.$TST.parent ?
+             activeTab.$TST.parent.$TST.lastChild :
+             Tab.getLastRootTab(activeTab.windowId))
       );
       return;
-    case 'focusNextSibling':
+    case 'focusNextSibling':
       TabsInternalOperation.activateTab(
         activeTab.$TST.nextSiblingTab ||
-          activeTab.$TST.parent && activeTab.$TST.parent.$TST.firstChild
+          (activeTab.$TST.parent ?
+             activeTab.$TST.parent.$TST.firstChild :
+             Tab.getFirstVisibleTab(activeTab.windowId))
       );
       return;
 

webextensions/common/Tab.js

@@ -2796,7 +2796,7 @@ Tab.getRootTabs = (windowId = null, options = {}) => {
 };
 
 Tab.getLastRootTab = (windowId, options = {}) => {
-  const tabs = this.getRootTabs(windowId, options);
+  const tabs = Tab.getRootTabs(windowId, options);
   return tabs[tabs.length - 1];
 };