Skip to content

Commit c8734dd

Browse files
committed
Pinned tabs can have different width and height
1 parent 1de646f commit c8734dd

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

webextensions/sidebar/size.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ let mTabXOffset = 0;
2323
let mTabYOffset = 0;
2424
let mFavIconSize = 0;
2525
let mFavIconizedTabSize = 0;
26+
let mFavIconizedTabWidth = 0;
27+
let mFavIconizedTabHeight = 0;
2628
let mFavIconizedTabXOffset = 0;
2729
let mFavIconizedTabYOffset = 0;
2830

@@ -59,11 +61,11 @@ export function getFavIconizedTabYOffset() {
5961
}
6062

6163
export function getRenderedFavIconizedTabWidth() {
62-
return mFavIconizedTabSize + mFavIconizedTabXOffset;
64+
return mFavIconizedTabWidth + mFavIconizedTabXOffset;
6365
}
6466

6567
export function getRenderedFavIconizedTabHeight() {
66-
return mFavIconizedTabSize + mFavIconizedTabYOffset;
68+
return mFavIconizedTabHeight + mFavIconizedTabYOffset;
6769
}
6870

6971
export function init() {
@@ -81,7 +83,10 @@ export function update() {
8183
--favicon-size: ${mFavIconSize}px;
8284
--faviconized-tab-size: ${mFavIconizedTabSize}px;
8385
}`;
84-
const faviconizedTabStyle = window.getComputedStyle(document.querySelector('#dummy-faviconized-tab'));
86+
const dummyFaviconizedTab = document.querySelector('#dummy-faviconized-tab');
87+
const faviconizedTabStyle = window.getComputedStyle(dummyFaviconizedTab);
88+
mFavIconizedTabWidth = dummyFaviconizedTab.offsetWidth;
89+
mFavIconizedTabHeight = dummyFaviconizedTab.offsetHeight;
8590
mFavIconizedTabXOffset = parseFloat(faviconizedTabStyle.marginLeft.replace(/px$/, '')) + parseFloat(faviconizedTabStyle.marginRight.replace(/px$/, ''));
8691
mFavIconizedTabYOffset = parseFloat(faviconizedTabStyle.marginTop.replace(/px$/, '')) + parseFloat(faviconizedTabStyle.marginBottom.replace(/px$/, ''));
8792

0 commit comments

Comments
 (0)