Update element when groupId is changed

piroor · piroor · commit dc24a42af0e4 · 2025-05-03T03:44:31.000+09:00
diff --git a/webextensions/common/Tab.js b/webextensions/common/Tab.js
@@ -1969,8 +1969,6 @@ export default class Tab {
     }
 
     this.setAttribute(Constants.kGROUP_ID, this.tab.groupId);
-    //const win = TabsStore.windows.get(this.tab.windowId);
-    //const group = win.tabGroups.get(this.tab.groupId);
   }
 
 
diff --git a/webextensions/sidebar/sidebar-tabs.js b/webextensions/sidebar/sidebar-tabs.js
@@ -581,6 +581,7 @@ function tryApplyUpdate(update) {
 
     if ('groupId' in update.updatedProperties) {
       tab.$TST.onNativeGroupModified();
+      tab.$TST.updateElement(TabUpdateTarget.TabProperties);
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -1969,8 +1969,6 @@ export default class Tab {`
`1969`	`1969`	`}`
`1970`	`1970`
`1971`	`1971`	`this.setAttribute(Constants.kGROUP_ID, this.tab.groupId);`
`1972`		`- //const win = TabsStore.windows.get(this.tab.windowId);`
`1973`		`- //const group = win.tabGroups.get(this.tab.groupId);`
`1974`	`1972`	`}`
`1975`	`1973`
`1976`	`1974`
Original file line number	Diff line number	Diff line change
`@@ -581,6 +581,7 @@ function tryApplyUpdate(update) {`
`581`	`581`
`582`	`582`	`if ('groupId' in update.updatedProperties) {`
`583`	`583`	`tab.$TST.onNativeGroupModified();`
	`584`	`+ tab.$TST.updateElement(TabUpdateTarget.TabProperties);`
`584`	`585`	`}`
`585`	`586`	`}`
`586`	`587`