Skip to content

Commit 0a22b7d

Browse files
committed
Add Get methods in image/helmchart services
Include replication_status in response [#170896432](https://www.pivotaltracker.com/story/show/170896432)
1 parent 29a8f55 commit 0a22b7d

File tree

4 files changed

+30
-16
lines changed

4 files changed

+30
-16
lines changed

helm_chart_references.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,13 @@ type HelmChartReferenceResponse struct {
2929
}
3030

3131
type HelmChartReference struct {
32-
ID int `json:"id,omitempty" yaml:"id,omitempty"`
33-
Description string `json:"description,omitempty" yaml:"description,omitempty"`
34-
DocsURL string `json:"docs_url,omitempty" yaml:"docs_url,omitempty"`
35-
Name string `json:"name,omitempty" yaml:"name,omitempty"`
36-
Version string `json:"version,omitempty" yaml:"version,omitempty"`
37-
SystemRequirements []string `json:"system_requirements,omitempty" yaml:"system_requirements,omitempty"`
32+
ID int `json:"id,omitempty" yaml:"id,omitempty"`
33+
Description string `json:"description,omitempty" yaml:"description,omitempty"`
34+
DocsURL string `json:"docs_url,omitempty" yaml:"docs_url,omitempty"`
35+
Name string `json:"name,omitempty" yaml:"name,omitempty"`
36+
Version string `json:"version,omitempty" yaml:"version,omitempty"`
37+
SystemRequirements []string `json:"system_requirements,omitempty" yaml:"system_requirements,omitempty"`
38+
ReplicationStatus ReplicationStatus `json:"replication_status,omitempty" yaml:"replication_status,omitempty"`
3839
}
3940

4041
type createUpdateHelmChartReferenceBody struct {

helm_chart_references_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -430,6 +430,7 @@ var _ = Describe("PivnetClient - helm chart references", func() {
430430
Name: createHelmChartReferenceConfig.Name,
431431
Version: createHelmChartReferenceConfig.Version,
432432
SystemRequirements: createHelmChartReferenceConfig.SystemRequirements,
433+
ReplicationStatus: pivnet.InProgress,
433434
}}
434435
})
435436

@@ -526,7 +527,7 @@ var _ = Describe("PivnetClient - helm chart references", func() {
526527
expectedRequestBody requestBody
527528
helmChartReference pivnet.HelmChartReference
528529
updateHelmChartReferenceUrl string
529-
validResponse = `{"helm_chart_reference":{"id":1234, "docs_url":"example.io", "system_requirements": ["1", "2"]}}`
530+
validResponse = `{"helm_chart_reference":{"id":1234, "docs_url":"example.io", "system_requirements": ["1", "2"], "replication_status": "in_progress"}}`
530531
)
531532

532533
BeforeEach(func() {
@@ -570,6 +571,7 @@ var _ = Describe("PivnetClient - helm chart references", func() {
570571
Expect(updatedHelmChartReference.ID).To(Equal(helmChartReference.ID))
571572
Expect(updatedHelmChartReference.DocsURL).To(Equal(helmChartReference.DocsURL))
572573
Expect(updatedHelmChartReference.SystemRequirements).To(ConsistOf("2", "1"))
574+
Expect(updatedHelmChartReference.ReplicationStatus).To(Equal(pivnet.InProgress))
573575
})
574576

575577
It("forwards the server-side error", func() {

image_references.go

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,24 @@ type ImageReferenceResponse struct {
2929
ImageReference ImageReference `json:"image_reference,omitempty"`
3030
}
3131

32+
type ReplicationStatus string
33+
34+
const (
35+
InProgress ReplicationStatus = "in_progress"
36+
Complete ReplicationStatus = "complete"
37+
FailedToReplicate ReplicationStatus = "failed_to_replicate"
38+
)
39+
3240
type ImageReference struct {
33-
ID int `json:"id,omitempty" yaml:"id,omitempty"`
34-
ImagePath string `json:"image_path,omitempty" yaml:"image_path,omitempty"`
35-
Description string `json:"description,omitempty" yaml:"description,omitempty"`
36-
Digest string `json:"digest,omitempty" yaml:"digest,omitempty"`
37-
DocsURL string `json:"docs_url,omitempty" yaml:"docs_url,omitempty"`
38-
Name string `json:"name,omitempty" yaml:"name,omitempty"`
39-
SystemRequirements []string `json:"system_requirements,omitempty" yaml:"system_requirements,omitempty"`
40-
ReleaseVersions []string `json:"release_versions,omitempty" yaml:"release_versions,omitempty"`
41+
ID int `json:"id,omitempty" yaml:"id,omitempty"`
42+
ImagePath string `json:"image_path,omitempty" yaml:"image_path,omitempty"`
43+
Description string `json:"description,omitempty" yaml:"description,omitempty"`
44+
Digest string `json:"digest,omitempty" yaml:"digest,omitempty"`
45+
DocsURL string `json:"docs_url,omitempty" yaml:"docs_url,omitempty"`
46+
Name string `json:"name,omitempty" yaml:"name,omitempty"`
47+
SystemRequirements []string `json:"system_requirements,omitempty" yaml:"system_requirements,omitempty"`
48+
ReleaseVersions []string `json:"release_versions,omitempty" yaml:"release_versions,omitempty"`
49+
ReplicationStatus ReplicationStatus `json:"replication_status,omitempty" yaml:"replication_status,omitempty"`
4150
}
4251

4352
type createUpdateImageReferenceBody struct {

image_references_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -526,6 +526,7 @@ var _ = Describe("PivnetClient - image references", func() {
526526
ImagePath: createImageReferenceConfig.ImagePath,
527527
Name: createImageReferenceConfig.Name,
528528
SystemRequirements: createImageReferenceConfig.SystemRequirements,
529+
ReplicationStatus: pivnet.InProgress,
529530
}}
530531
})
531532

@@ -622,7 +623,7 @@ var _ = Describe("PivnetClient - image references", func() {
622623
expectedRequestBody requestBody
623624
imageReference pivnet.ImageReference
624625
updateImageReferenceUrl string
625-
validResponse = `{"image_reference":{"id":1234, "docs_url":"example.io", "system_requirements": ["1", "2"]}}`
626+
validResponse = `{"image_reference":{"id":1234, "docs_url":"example.io", "system_requirements": ["1", "2"], "replication_status": "in_progress"}}`
626627
)
627628

628629
BeforeEach(func() {
@@ -668,6 +669,7 @@ var _ = Describe("PivnetClient - image references", func() {
668669
Expect(updatedImageReference.ID).To(Equal(imageReference.ID))
669670
Expect(updatedImageReference.DocsURL).To(Equal(imageReference.DocsURL))
670671
Expect(updatedImageReference.SystemRequirements).To(ConsistOf("2", "1"))
672+
Expect(updatedImageReference.ReplicationStatus).To(Equal(pivnet.InProgress))
671673
})
672674

673675
It("forwards the server-side error", func() {

0 commit comments

Comments
 (0)