feat: only stemcell match when provided in template

Author: notrepo05

internal/component/artifactory_release_source.go

@@ -178,6 +178,15 @@ func (ars *ArtifactoryReleaseSource) findReleaseVersion(spec, searchSpec cargo.B
 		return cargo.BOSHReleaseTarballLock{}, err
 	}
 
+	names := re.SubexpNames()
+	hasStemcellGroup := false
+	for _, name := range names {
+		if name == reStemcellVersionGroup {
+			hasStemcellGroup = true
+			break
+		}
+	}
+
 	foundRelease := cargo.BOSHReleaseTarballLock{}
 	for _, artifactoryFile := range artifactoryFiles {
 		if artifactoryFile.Folder {
@@ -187,7 +196,6 @@ func (ars *ArtifactoryReleaseSource) findReleaseVersion(spec, searchSpec cargo.B
 		if matches == nil {
 			continue
 		}
-		names := re.SubexpNames()
 		matchedGroups := map[string]string{}
 		for i, n := range names {
 			if i == 0 || n == "" {
@@ -197,9 +205,7 @@ func (ars *ArtifactoryReleaseSource) findReleaseVersion(spec, searchSpec cargo.B
 		}
 
 		version := matchedGroups[reReleaseVersionGroup]
-		stemcellVersion := matchedGroups[reStemcellVersionGroup]
-		// we aren't updating stemcell version
-		if stemcellVersion != spec.StemcellVersion {
+		if hasStemcellGroup && matchedGroups[reStemcellVersionGroup] != spec.StemcellVersion {
 			continue
 		}
 

internal/component/artifactory_release_source_test.go

@@ -344,6 +344,25 @@ var _ = Describe("interacting with BOSH releases on Artifactory", func() {
 					Expect(resultErr).NotTo(HaveOccurred())
 					Expect(local.LocalPath).To(BeAnExistingFile())
 				})
+
+				It("still finds the release when the spec has stemcell info from the lock file", func() {
+					resultLock, resultErr := source.FindReleaseVersion(cargo.BOSHReleaseTarballSpecification{
+						Name:            "mango",
+						Version:         "*",
+						StemcellOS:      "smoothie",
+						StemcellVersion: "9.9",
+					}, false)
+
+					Expect(resultErr).NotTo(HaveOccurred())
+					Expect(resultLock).To(Equal(cargo.BOSHReleaseTarballLock{
+						Name:         "mango",
+						Version:      "2.3.4",
+						SHA1:         "some-sha",
+						RemotePath:   "bosh-releases/mango-2.3.4.tgz",
+						RemoteSource: "some-mango-tree",
+					}))
+				})
+
 				When("the server URL ends in /artifactory", func() {
 					JustBeforeEach(func() {
 						logger := log.New(GinkgoWriter, "", 0)