refactor: rename jobMFConsumes → boshConsumes

The jobMF prefix is overly specific to where the struct is used.
boshConsumes better names what it represents: the BOSH job spec
consumes schema (name/type/optional only).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: drich10

internal/carvel/baker.go

@@ -322,10 +322,9 @@ type boshLinkConsumer struct {
 	Deployment string `yaml:"deployment,omitempty"`
 }
 
-// jobMFConsumes is the subset of boshLinkConsumer fields that are valid in a
-// BOSH job.MF spec consumes list. From/Deployment are runtime-config-only and
-// must not appear in job.MF.
-type jobMFConsumes struct {
+// boshConsumes is the BOSH job spec consumes schema: name, type, and optional only.
+// From/Deployment are runtime-config-only and must not appear in the job spec.
+type boshConsumes struct {
 	Name     string `yaml:"name"`
 	Type     string `yaml:"type"`
 	Optional bool   `yaml:"optional"`
@@ -476,11 +475,11 @@ files:
 	}
 	deduped := b.deduplicateConsumes(allConsumes)
 
-	jobMFLinks := make([]jobMFConsumes, len(deduped))
+	boshLinks := make([]boshConsumes, len(deduped))
 	for i, c := range deduped {
-		jobMFLinks[i] = jobMFConsumes{Name: c.Name, Type: c.Type, Optional: c.Optional}
+		boshLinks[i] = boshConsumes{Name: c.Name, Type: c.Type, Optional: c.Optional}
 	}
-	registryDataSpec, err := buildRegistryDataSpec(registryDataTemplates, registryDataProperties, jobMFLinks)
+	registryDataSpec, err := buildRegistryDataSpec(registryDataTemplates, registryDataProperties, boshLinks)
 	if err != nil {
 		return err
 	}
@@ -496,7 +495,7 @@ files:
 // buildRegistryDataSpec constructs the job.MF content for the registry-data BOSH job.
 // It always includes the hardcoded cluster-info link and appends any additional links
 // collected from *.job-spec-overlay.yml sidecars in the packageinstalls/ directory.
-func buildRegistryDataSpec(templates, properties string, additionalLinks []jobMFConsumes) (string, error) {
+func buildRegistryDataSpec(templates, properties string, additionalLinks []boshConsumes) (string, error) {
 	extraLinks := ""
 	if len(additionalLinks) > 0 {
 		data, err := yaml.Marshal(additionalLinks)

internal/carvel/baker_test.go

@@ -124,7 +124,7 @@ var _ = Describe("Carvel Baker", func() {
 
 	Context("buildRegistryDataSpec", func() {
 		It("includes user-declared additional links after cluster-info", func() {
-			links := []jobMFConsumes{
+			links := []boshConsumes{
 				{Name: "binding_cache", Type: "binding_cache", Optional: false},
 			}
 			spec, err := buildRegistryDataSpec("", "", links)
@@ -136,7 +136,7 @@ var _ = Describe("Carvel Baker", func() {
 		})
 
 		It("marks optional links correctly", func() {
-			links := []jobMFConsumes{
+			links := []boshConsumes{
 				{Name: "optional-link", Type: "some-type", Optional: true},
 			}
 			spec, err := buildRegistryDataSpec("", "", links)
@@ -154,7 +154,7 @@ var _ = Describe("Carvel Baker", func() {
 		It("safely encodes link names containing YAML-special characters", func() {
 			// yaml.Marshal quotes/blocks the value so it cannot inject extra YAML keys.
 			// The real type field ("legit-type") must still appear at the correct level.
-			links := []jobMFConsumes{
+			links := []boshConsumes{
 				{Name: "name: injected\ntype: evil", Type: "legit-type", Optional: false},
 			}
 			spec, err := buildRegistryDataSpec("", "", links)
@@ -163,7 +163,7 @@ var _ = Describe("Carvel Baker", func() {
 		})
 
 		It("emits each unique link name only once given pre-deduplicated input", func() {
-			links := []jobMFConsumes{
+			links := []boshConsumes{
 				{Name: "binding_cache", Type: "binding_cache", Optional: false},
 			}
 			spec, err := buildRegistryDataSpec("", "", links)