Move verbose out of testPlan; pass as parameter to script()

testPlan is a pure data value describing which suites to run. Verbosity
is a rendering concern: it only affects the generated shell script, not
what tests are selected. Changing the signature to script(verbose bool)
makes this explicit at the call site and removes the hidden coupling
between plan construction and script rendering.

ai-assisted=yes

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: rizwanreza

internal/test/container.go

@@ -67,9 +67,8 @@ type Configuration struct {
 // setup that must succeed before any suite, and an ordered list of named
 // suites each of which is run as an independent unit.
 type testPlan struct {
-	setup   []string // fail-fast preamble (git config, etc.)
-	suites  []suiteStep
-	verbose bool // when true: timestamps before each suite; npm output visible
+	setup  []string // fail-fast preamble (git config, etc.)
+	suites []suiteStep
 }
 
 // suiteStep is one test suite — migrations, stability, or manifest.
@@ -93,8 +92,7 @@ func (configuration Configuration) commands() (testPlan, error) {
 	tileDirName := filepath.Base(configuration.AbsoluteTileDirectory)
 
 	plan := testPlan{
-		setup:   []string{"git config --global --add safe.directory '*'"},
-		verbose: configuration.Verbose,
+		setup: []string{"git config --global --add safe.directory '*'"},
 	}
 
 	if configuration.RunMigrations || configuration.RunAll {
@@ -144,8 +142,9 @@ func (configuration Configuration) commands() (testPlan, error) {
 // Each suite runs in a subshell so cd calls don't leak between suites. Exit
 // codes are captured individually. When more than one suite is selected a
 // colored pass/fail summary is printed at the end. The script always exits
-// non-zero if any suite failed.
-func (p testPlan) script() string {
+// non-zero if any suite failed. When verbose is true, start/end timestamps
+// are echoed before and after each suite.
+func (p testPlan) script(verbose bool) string {
 	var b strings.Builder
 
 	// Global setup — fail fast on any error.
@@ -160,12 +159,12 @@ func (p testPlan) script() string {
 
 	// One subshell per suite; exit code and end-time stored in _exitN / _timeN.
 	for i, s := range p.suites {
-		if p.verbose {
+		if verbose {
 			fmt.Fprintf(&b, "\necho \"[$(date '+%%H:%%M:%%S')] Starting: %s\"\n", s.name)
 		}
 		fmt.Fprintf(&b, "\n(%s); _exit%d=$?\n", strings.Join(s.cmds, " && "), i)
 		fmt.Fprintf(&b, "_time%d=$(date '+%%H:%%M:%%S')\n", i)
-		if p.verbose {
+		if verbose {
 			fmt.Fprintf(&b, "echo \"[$_time%d] Completed: %s\"\n", i, s.name)
 		}
 	}
@@ -233,7 +232,7 @@ func runTest(ctx context.Context, w io.Writer, dockerDaemon mobyClient, configur
 	tileDir := filepath.Base(configuration.AbsoluteTileDirectory)
 	envVars := getTileTestEnvVars(configuration.AbsoluteTileDirectory, tileDir, envMap)
 
-	return startAndWaitContainer(ctx, w, dockerDaemon, plan.script(), envVars, parentDir, configuration.Verbose)
+	return startAndWaitContainer(ctx, w, dockerDaemon, plan.script(configuration.Verbose), envVars, parentDir, configuration.Verbose)
 }
 
 // buildTestImage builds the kiln test Docker image, forwarding Artifactory

internal/test/container_test.go

@@ -160,7 +160,7 @@ func TestTestPlan_script_includesSummaryForMultipleSuites(t *testing.T) {
 		},
 	}
 
-	script := plan.script()
+	script := plan.script(false)
 
 	// Each suite runs in a subshell with captured exit code.
 	require.Contains(t, script, "); _exit0=$?")
@@ -199,7 +199,7 @@ func TestTestPlan_script_omitsSummaryForSingleSuite(t *testing.T) {
 		},
 	}
 
-	script := plan.script()
+	script := plan.script(false)
 
 	// No summary text for single suite.
 	require.NotContains(t, script, "Passed")
@@ -213,7 +213,7 @@ func TestTestPlan_script_emptyWithNoSuites(t *testing.T) {
 	plan := testPlan{
 		setup: []string{"git config --global --add safe.directory '*'"},
 	}
-	script := plan.script()
+	script := plan.script(false)
 	require.Contains(t, script, "git config")
 	require.NotContains(t, script, "_exit0")
 	require.NotContains(t, script, "_overall")
@@ -294,15 +294,14 @@ func TestConfiguration_commands_usesNpmInstallWithoutLockfile(t *testing.T) {
 
 func TestTestPlan_script_verbose_addsStartAndEndTimestamps(t *testing.T) {
 	plan := testPlan{
-		setup:   []string{"setup cmd"},
-		verbose: true,
+		setup: []string{"setup cmd"},
 		suites: []suiteStep{
 			{name: "Migration Tests", cmds: []string{"npm test"}},
 			{name: "Stability Tests", cmds: []string{"ginkgo stability"}},
 		},
 	}
 
-	script := plan.script()
+	script := plan.script(true)
 
 	// Start and end echo lines present for each suite.
 	require.Contains(t, script, "Starting: Migration Tests")
@@ -313,12 +312,11 @@ func TestTestPlan_script_verbose_addsStartAndEndTimestamps(t *testing.T) {
 
 func TestTestPlan_script_noStartEndEchoWhenNotVerbose(t *testing.T) {
 	plan := testPlan{
-		setup:   []string{"setup cmd"},
-		verbose: false,
-		suites:  []suiteStep{{name: "Migration Tests", cmds: []string{"npm test"}}},
+		setup:  []string{"setup cmd"},
+		suites: []suiteStep{{name: "Migration Tests", cmds: []string{"npm test"}}},
 	}
 
-	script := plan.script()
+	script := plan.script(false)
 
 	// No verbose echo lines; end-time variable is still captured for potential summary use.
 	require.NotContains(t, script, "Starting:")