fix(carvel): address PR review comments on structured variable declarations

- Fix indentation of Variables[0] assertions to match surrounding 5-tab style
- Add Options assertions (common_name, is_ca) to verify round-trip fidelity of
  the full variable definition including nested options block
- Refactor validateVariables to use errors.Join so all malformed entries are
  reported in a single error instead of failing on the first one
- Fix pre-existing AfterEach indentation so gofmt is clean

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: drich10

internal/carvel/baker.go

@@ -255,17 +255,16 @@ func (b *baker) progress(message string) {
 	_, _ = fmt.Fprintln(b.progressWriter, message)
 }
 
-// validateVariables checks that each variable declaration has the required name and type fields.
 func validateVariables(vars []proofing.Variable) error {
+	var errs []error
 	for i, v := range vars {
 		if v.Name == "" {
-			return fmt.Errorf("variables[%d]: missing required field 'name'", i)
-		}
-		if v.Type == "" {
-			return fmt.Errorf("variables[%d] (%q): missing required field 'type'", i, v.Name)
+			errs = append(errs, fmt.Errorf("variables[%d]: missing required field 'name'", i))
+		} else if v.Type == "" {
+			errs = append(errs, fmt.Errorf("variables[%d] (%q): missing required field 'type'", i, v.Name))
 		}
 	}
-	return nil
+	return errors.Join(errs...)
 }
 
 func (b *baker) generateBoshReleaseDir() error {

internal/carvel/baker_test.go

@@ -141,12 +141,12 @@ var _ = Describe("Carvel Baker", func() {
 				subject = NewBaker()
 				subject.SetWriter(GinkgoWriter)
 			})
-		AfterEach(func() {
-			// Clean up the temp directory
-			if inputPath != "" {
-				_ = os.RemoveAll(filepath.Dir(inputPath))
-			}
-		})
+			AfterEach(func() {
+				// Clean up the temp directory
+				if inputPath != "" {
+					_ = os.RemoveAll(filepath.Dir(inputPath))
+				}
+			})
 			JustBeforeEach(func() {
 				err = subject.Bake(inputPath)
 			})
@@ -171,8 +171,10 @@ var _ = Describe("Carvel Baker", func() {
 					Expect(outMeta.PropertyBlueprints).To(HaveLen(2))
 					Expect(outMeta.FormTypes).To(HaveLen(1))
 					Expect(outMeta.Variables).To(HaveLen(1))
-				Expect(outMeta.Variables[0].Name).To(Equal("sample-tile-ca"))
-				Expect(outMeta.Variables[0].Type).To(Equal("certificate"))
+					Expect(outMeta.Variables[0].Name).To(Equal("sample-tile-ca"))
+					Expect(outMeta.Variables[0].Type).To(Equal("certificate"))
+					Expect(outMeta.Variables[0].Options).To(HaveKeyWithValue("common_name", "Sample Tile CA"))
+					Expect(outMeta.Variables[0].Options).To(HaveKeyWithValue("is_ca", true))
 					Expect(outMeta.Releases).To(HaveLen(1))
 					Expect(outMeta.Releases[0]).To(ContainSubstring("k8s-tile-test"))
 					Expect(outMeta.InstanceGroups).To(HaveLen(0))