Support multiple tags (#701)

Co-authored-by: Sridharan <[email protected]>

Author: krsri

vmlifecycle/vmmanagers/azure.go

@@ -91,6 +91,48 @@ type AzureVMManager struct {
 	pollingInterval time.Duration
 }
 
+func ParseTagsString(tagsStr string) []string {
+	var tags []string
+	var current strings.Builder
+	inQuotes := false
+	quoteChar := byte(0)
+
+	for i := 0; i < len(tagsStr); i++ {
+		char := tagsStr[i]
+
+		if inQuotes {
+			if char == quoteChar {
+				// End of quoted string
+				inQuotes = false
+				quoteChar = 0
+			} else {
+				current.WriteByte(char)
+			}
+		} else {
+			if char == '"' || char == '\'' {
+				// Start of quoted string
+				inQuotes = true
+				quoteChar = char
+			} else if char == ' ' {
+				// Space → end of tag
+				if current.Len() > 0 {
+					tags = append(tags, strings.TrimSpace(current.String()))
+					current.Reset()
+				}
+			} else {
+				current.WriteByte(char)
+			}
+		}
+	}
+
+	// Add last tag if buffer not empty
+	if current.Len() > 0 {
+		tags = append(tags, strings.TrimSpace(current.String()))
+	}
+
+	return tags
+}
+
 func NewAzureVMManager(stdout, stderr io.Writer, config *OpsmanConfigFilePayload, imageYaml string, state StateInfo, azureRunner azureRunner, t time.Duration) *AzureVMManager {
 	return &AzureVMManager{
 		stdout:          stdout,
@@ -506,7 +548,12 @@ func (a *AzureVMManager) createVM(imageUrl string, imageID string, publicIP stri
 	}
 
 	if azure.Tags != "" {
-		args = append(args, "--tags", azure.Tags)
+		// Parse tags string respecting quoted values that may contain spaces
+		tags := ParseTagsString(azure.Tags)
+		args = append(args, "--tags")
+		for _, tag := range tags {
+			args = append(args, tag)
+		}
 	}
 
 	_, _, err = a.runner.ExecuteWithEnvVars(a.addEnvVars(), args)

vmlifecycle/vmmanagers/azure_test.go

@@ -211,7 +211,7 @@ opsman-configuration:
 						"--private-ip-address", "10.0.0.3",
 						"--storage-sku", "Standard_LRS",
 						"--image", "/some/resource/id/image",
-						"--tags", "Project=ECommerce CostCenter=00123 Team=Web",
+						"--tags", "Project=ECommerce", "CostCenter=00123", "Team=Web",
 					},
 					{
 						"storage", "blob", "delete-batch",
@@ -227,6 +227,68 @@ opsman-configuration:
 				}
 			})
 
+			It("passes multiple tags as separate arguments", func() {
+				const configWithMultipleTags = `
+opsman-configuration:
+  azure:
+    vm_name: vm-name
+    subscription_id: subscription
+    resource_group: rg
+    tenant_id: tenant
+    client_id: client
+    client_secret: secret
+    location: %s
+    public_ip: 1.2.3.4
+    private_ip: 10.0.0.3
+    container: opsman_container
+    boot_disk_size: 200
+    network_security_group: nsg
+    subnet_id: /subscriptions/sub-guid/resourceGroups/network-resource-group/providers/Microsoft.Network/virtualNetworks/vnet1/subnets/sub1
+    storage_account: account
+    storage_key: key
+    ssh_public_key: asdfasdfs
+    cloud_name: AzureGermanCloud
+    tags: "foo 'bar=single quote' \"key=double quote\" key1=\"value\" key2=value2 key3=\"value with spaces\" key4='value with single quotes' key5=simple key6=\"quoted=equals\" key7='single=equals'"
+`
+				setupCommand(configWithMultipleTags)
+				status, stateInfo, err := command.CreateVM()
+				Expect(err).ToNot(HaveOccurred())
+				Expect(status).To(Equal(vmmanagers.Success))
+				Expect(stateInfo).To(Equal(vmmanagers.StateInfo{IAAS: "azure", ID: "vm-name"}))
+
+				// Find the vm create command call
+				var vmCreateArgs []interface{}
+				for i := 0; i < runner.ExecuteWithEnvVarsCallCount(); i++ {
+					_, args := runner.ExecuteWithEnvVarsArgsForCall(i)
+					if len(args) > 0 && args[0] == "vm" && args[1] == "create" {
+						vmCreateArgs = args
+						break
+					}
+				}
+				Expect(vmCreateArgs).ToNot(BeNil())
+
+				// Verify that tags are passed as separate arguments
+				Expect(vmCreateArgs).To(ContainElement("--tags"))
+
+				// Test key without value
+				Expect(vmCreateArgs).To(ContainElement("foo"))
+
+				// Test simple key=value pairs
+				Expect(vmCreateArgs).To(ContainElement("key2=value2"))
+				Expect(vmCreateArgs).To(ContainElement("key5=simple"))
+
+				// Test single quotes
+				Expect(vmCreateArgs).To(ContainElement("bar=single quote"))
+				Expect(vmCreateArgs).To(ContainElement("key4=value with single quotes"))
+				Expect(vmCreateArgs).To(ContainElement("key7=single=equals"))
+
+				// Test double quotes
+				Expect(vmCreateArgs).To(ContainElement("key=double quote"))
+				Expect(vmCreateArgs).To(ContainElement("key1=value"))
+				Expect(vmCreateArgs).To(ContainElement("key3=value with spaces"))
+				Expect(vmCreateArgs).To(ContainElement("key6=quoted=equals"))
+			})
+
 			Context("DEPRECATED tests", func() {
 				const configWithManagedDiskAndUnmanagedDiskStrTemplateDEPRECATED = `
 opsman-configuration: