video-swap-new mute / volume state changing after ad

[Crimsonology]

Hello,

I have attempted to update the volume via copying the script then updating the player_volume from 0.5 to lower more so to match the volume I generally run streams at (10-20%). However when I tried to use the permalink, the script no longer blocks adds. Is there something that I might be doing wrong in this instance?

Any help would be appreciated, thank you.

[pixeltris]

I'm not sure what you're asking. You're talking about this line of code?

TwitchAdSolutions/vaft/vaft.user.js

Line 625 in 492c1db

player_volume: 0.0,

Which belongs to this function:

TwitchAdSolutions/vaft/vaft.user.js

Line 607 in 492c1db

async function tryNotifyTwitch(streamM3u8) {

That is currently unused code. It was used to notify that ads have been watched to prevent prerolls on every refresh but the caller was commented out as the ad watched notification is no longer required.

TwitchAdSolutions/vaft/vaft.user.js

Line 524 in 492c1db

//tryNotifyTwitch(textStr);

Are you having problems with the players volume? Or something else?

[Crimsonology]

I have not tried the vaft option yet that you have suggested, only this one https://github.com/pixeltris/TwitchAdSolutions/blob/master/video-swap-new/video-swap-new-ublock-origin.js.

It's on line 489 of that file, play_volume: 0.5, and then on lines 639-656 it looks like that is storing the current player volume but after the video swap is done, it defaults to the 50% from line 489.

I've tried to copy the script over to change that line specifically and test via my own github (to see if I could change the volume myself there) but the video swap no longer works from my own raw permalink. I resorted to turning down my browser via the volume mixer on windows and left it at the 50% volume that it was defaulting to.

Thank you, I appreciate the assistance, I will maybe give the vaft option a try today instead.

[pixeltris]

Yea, sorry I linked the wrong one. The stuff that mentions player_volume in video-swap-new is the same as vaft. It's just ad notification code, it isn't being used (no references to that code), and it isn't setting volume to 0.5, it's just telling Twitch what volume the player is at when an ad is watched.

It could be an issue with the local storage code you mentioned:

TwitchAdSolutions/video-swap-new/video-swap-new.user.js

Lines 651 to 669 in 492c1db

	const lsKeyQuality = 'video-quality';
	const lsKeyMuted = 'video-muted';
	const lsKeyVolume = 'volume';
	var currentQualityLS = localStorage.getItem(lsKeyQuality);
	var currentMutedLS = localStorage.getItem(lsKeyMuted);
	var currentVolumeLS = localStorage.getItem(lsKeyVolume);
	if (player?.core?.state) {
	localStorage.setItem(lsKeyMuted, JSON.stringify({default:player.core.state.muted}));
	localStorage.setItem(lsKeyVolume, player.core.state.volume);
	}
	if (player?.core?.state?.quality?.group) {
	localStorage.setItem(lsKeyQuality, JSON.stringify({default:player.core.state.quality.group}));
	}
	playerState.setSrc({ isNewMediaPlayerInstance: true, refreshAccessToken: true });
	setTimeout(() => {
	localStorage.setItem(lsKeyQuality, currentQualityLS);
	localStorage.setItem(lsKeyMuted, currentMutedLS);
	localStorage.setItem(lsKeyVolume, currentVolumeLS);
	}, 3000);

What that code attempts to do is preserve the volume/mute status for the current player as the script invokes a player reload after ads which triggers loading the volume/mute status from local storage. This might be a problem if you have many different tabs open as each will temporarily be setting the volume/mute status as ads trigger. Also depending on the timing if you happen to open a new Twitch tab in that 3 second window (the last line of code seen above), you may get volume/mute status values which are unexpected. But generally the volume/mute status should be preserved and as expected as you navigate through different pages. There isn't any code which sets the volume to 50%.

The following also does similar to prevent volume/mute status changes on player reload (this following code is preferable, but doesn't work on firefox which is why there are two versions of essentially the same thing):

TwitchAdSolutions/video-swap-new/video-swap-new.user.js

Lines 712 to 737 in 492c1db

	// Hooks for preserving volume / resolution
	var keysToCache = [
	'video-quality',
	'video-muted',
	'volume',
	'lowLatencyModeEnabled',// Low Latency
	'persistenceEnabled',// Mini Player
	];
	var cachedValues = new Map();
	for (var i = 0; i < keysToCache.length; i++) {
	cachedValues.set(keysToCache[i], localStorage.getItem(keysToCache[i]));
	}
	var realSetItem = localStorage.setItem;
	localStorage.setItem = function(key, value) {
	if (cachedValues.has(key)) {
	cachedValues.set(key, value);
	}
	realSetItem.apply(this, arguments);
	};
	var realGetItem = localStorage.getItem;
	localStorage.getItem = function(key) {
	if (cachedValues.has(key)) {
	return cachedValues.get(key);
	}
	return realGetItem.apply(this, arguments);
	};

[DiabloStorm]

Just replying with the requested info... I use Chrome.

[Beccanical]

If anyone else with a similar problem is using Chrome, the problem is likely that Chrome is not persisting the audio permissions.

While Twitch is open, click on the site information button to the direct left of the URL and click on Site Settings or go to the menu dropdown → Settings → Privacy and Security → Site Settings and navigate to the settings for "www.twitch.tv".

Then change the "🔊 Sound" setting from "Automatic" to "Allow".