Skip to content

Bug fix: DeviseRecognisable::Guard should still function even if request to Geocoder returns 500 #88

@JonathanAndrews

Description

@JonathanAndrews

Context:

A request to Geocoder is made to calculate the geographical distance between previous session address and current session address. The gem should handle a failed request.

Implementation notes:

  • Check if any of the requests is failing.
  • Move forward in the code, skipping requests to Geocoder if it does.
  • Return information that the geographical distance was not calculated.
  • In debug mode, we should know that the request to Geocoder was tried and failed in Rollbar.
  • Stub the request to Geocoder and raise an error. The user should still be able to log in.
  • Check that the class of Rollbar receives the information about the failed request to Geocoder.

Metadata

Metadata

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

Status
Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions