Skip to content

Commit 3a19cbc

Browse files
authored
Merge pull request #542 from pixijs/521-bug-v8-memoized-component-renders-after-being-unmounted
Destroy application on unmount
2 parents b6e870f + f3cc9e5 commit 3a19cbc

21 files changed

+411
-55
lines changed

.github/actions/setup/action.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ runs:
2929
shell: bash
3030
run: npm ci --ignore-scripts --no-audit --no-fund
3131

32-
- name: Rebuild binaries
33-
if: steps.node-modules-cache.outputs.cache-hit != 'true'
34-
shell: bash
35-
run: npm rebuild
32+
# - name: Rebuild binaries
33+
# if: steps.node-modules-cache.outputs.cache-hit != 'true'
34+
# shell: bash
35+
# run: npm rebuild

.github/workflows/handle-release-branch-push.yml

+34-3
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838
run: npm run ${{ matrix.script.command }}
3939

4040
publish:
41-
name: Publish
41+
name: 'Publish: Release'
4242
needs:
4343
- verify
4444
if: contains(fromJson('["refs/heads/alpha", "refs/heads/beta", "refs/heads/main"]'), github.ref)
@@ -49,14 +49,14 @@ jobs:
4949
with:
5050
fetch-depth: 0
5151

52-
- name: Setup Project
52+
- name: Setup project
5353
uses: ./.github/actions/setup
5454

5555
- name: Build Project
5656
run: npm run build
5757
shell: bash
5858

59-
- name: Semantic Release
59+
- name: Semantic release
6060
env:
6161
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6262
id: release
@@ -71,3 +71,34 @@ jobs:
7171
if: ${{ steps.release.outputs.new_tag_version != '' }}
7272
run: npm publish ./dist/*.tgz --tag ${{ (github.head_ref || github.ref_name) == 'main' && 'latest' || github.head_ref || github.ref_name }}
7373
shell: bash
74+
75+
# dev-publish:
76+
# name: 'Publish: Dev'
77+
# needs:
78+
# - verify
79+
# if: contains(fromJson('["refs/heads/alpha", "refs/heads/beta", "refs/heads/main"]'), github.ref) == 'false'
80+
# runs-on: ubuntu-latest
81+
# steps:
82+
# - name: Checkout
83+
# uses: actions/checkout@v4
84+
# with:
85+
# fetch-depth: 0
86+
87+
# - name: Setup project
88+
# uses: ./.github/actions/setup
89+
90+
# - name: Build project
91+
# run: npm run build
92+
# shell: bash
93+
94+
# - name: Get current version
95+
# run: echo "PACKAGE_VERSION=$(npm pkg get version | tr -d '"')" >> $GITHUB_ENV
96+
97+
# - name: Setup dev version
98+
# run: echo "BRANCH_VERSION=$PACKAGE_VERSION-$BRANCH_NAME.${GITHUB_SHA::7}" >> $GITHUB_ENV
99+
100+
# - name: Bump version
101+
# run: npm version $BRANCH_VERSION --no-git-tag-version --force
102+
103+
# - name: Publish a dev release
104+
# run: npm publish --tag dev

0 commit comments

Comments
 (0)