fixed the UTC encoding of the TimeEncoding.MAX_INSTANT

Author: xpromache

yamcs-core/src/main/java/org/yamcs/utils/TaiUtcConverter.java

@@ -180,7 +180,7 @@ private void caldateFromMjd(DateTimeComponents cd, long day) {
     private long caldateToMjd(DateTimeComponents dtc) {
         int y;
         int m;
-        int d;
+        long d;
 
         d = dtc.day - 678882;
         m = dtc.month - 1;

yamcs-core/src/test/java/org/yamcs/utils/TimeEncodingTest.java

@@ -240,10 +240,11 @@ public void checkMaxInstantValue() {
         // Assert that TimeEncoding can encode/decode with MAX_INSTANT
         String sMax = TimeEncoding.toString(TimeEncoding.MAX_INSTANT);
         long decodedMax = TimeEncoding.parse(sMax);
+        assertEquals(TimeEncoding.MAX_INSTANT, decodedMax);
+
         String sRMax = TimeEncoding.toString(decodedMax);
-        assertTrue(sMax.equals(sRMax));
+        assertEquals(sMax, sRMax);
 
-        // Assert that TimeEncoding fails to encode/decode with MAX_INSTANT + 1
         assertEquals("+inf", TimeEncoding.toString(TimeEncoding.MAX_INSTANT + 1));
     }
 }