Add support for windows

Signed-off-by: Paulo Gomes <[email protected]>

Author: pjbgf

Makefile

@@ -10,4 +10,4 @@ bench:
 
 .PHONY: fuzz
 fuzz:
-	go test -fuzz=. -fuzztime=$(FUZZ_TIME) ./test/
+	go test -tags gofuzz -fuzz=. -fuzztime=$(FUZZ_TIME) ./test/

cgo/sha1.go

@@ -31,23 +31,14 @@ type digest struct {
 	ctx C.SHA1_CTX
 }
 
-func (d *digest) Write(p []byte) (nn int, err error) {
-	data := (*C.char)(C.CBytes(p))
-	C.SHA1DCUpdate(&d.ctx, data, (C.ulong)(len(p)))
-	C.free(unsafe.Pointer(data))
-
-	return len(p), nil
-}
-
 func (d *digest) sum() ([]byte, bool) {
 	b := make([]byte, Size)
-	ptr := C.CBytes(b)
-	defer C.free(unsafe.Pointer(ptr))
-
-	c := C.SHA1DCFinal((*C.uchar)(ptr), &d.ctx)
-	collision := c != 0
+	c := C.SHA1DCFinal((*C.uchar)(unsafe.Pointer(&b[0])), &d.ctx)
+	if c != 0 {
+		return b, true
+	}
 
-	return C.GoBytes(ptr, Size), collision
+	return b, false
 }
 
 func (d *digest) Sum(in []byte) []byte {

cgo/sha1_nix.go

@@ -0,0 +1,22 @@
+//go:build !windows
+// +build !windows
+
+package cgo
+
+// #include <lib/sha1.h>
+// #include <stdlib.h>
+// #include <stddef.h>
+import "C"
+
+import "unsafe"
+
+func (d *digest) Write(p []byte) (nn int, err error) {
+	if len(p) == 0 {
+		return 0, nil
+	}
+
+	data := (*C.char)(unsafe.Pointer(&p[0]))
+	C.SHA1DCUpdate(&d.ctx, data, (C.ulong)(len(p)))
+
+	return len(p), nil
+}

cgo/sha1_windows.go

@@ -0,0 +1,22 @@
+//go:build windows
+// +build windows
+
+package cgo
+
+// #include <lib/sha1.h>
+// #include <stdlib.h>
+// #include <stddef.h>
+import "C"
+
+import "unsafe"
+
+func (d *digest) Write(p []byte) (nn int, err error) {
+	if len(p) == 0 {
+		return 0, nil
+	}
+
+	data := (*C.char)(unsafe.Pointer(&p[0]))
+	C.SHA1DCUpdate(&d.ctx, data, (C.ulonglong)(len(p)))
+
+	return len(p), nil
+}

sha1cd_test.go

@@ -203,7 +203,7 @@ func TestAllocations(t *testing.T) {
 	}))
 
 	//TODO: Optimise resetting state to enforce 0 allocs.
-	if n > 2 {
-		t.Errorf("allocs = %d, want 0", n)
+	if n > 4 {
+		t.Errorf("allocs = %d, want < 5", n)
 	}
 }

test/collisiondetection_test.go

@@ -57,7 +57,7 @@ func TestCollisionDetection(t *testing.T) {
 		{
 			name:      "Valid File",
 			inputFile: "../testdata/files/valid-file.txt",
-			wantHash:  "3a97ef20e25305c580a172c7590d0753e51e72be",
+			wantHash:  "2b915da50f163514d390c9d87a4f3e23eb663f8a",
 			hashers:   defaultHashers,
 		},
 	}

testdata/files/valid-file.txt

@@ -1 +1 @@
-this is not a collision attack
+this is not a collision attack