Skip to content

Commit 498ba2e

Browse files
authored
Replace blanket-exclusion of TF Lite tests with --build_tests_only (tensorflow#22195)
PiperOrigin-RevId: 212065169
1 parent 7001057 commit 498ba2e

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

tensorflow/contrib/lite/tools/accuracy/ilsvrc/BUILD

+1
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ tf_cc_test(
5454
linkopts = common_linkopts,
5555
linkstatic = 1,
5656
tags = [
57+
"no_oss", # b/114307765
5758
"tflite_not_portable_android",
5859
"tflite_not_portable_ios",
5960
],

tensorflow/tools/ci_build/ci_parameterized_build.sh

+7-8
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,6 @@
8585
# Use the specified configurations when building.
8686
# When set, overrides TF_BUILD_IS_OPT and TF_BUILD_MAVX
8787
# options, as this will replace the two.
88-
# TF_SKIP_LITE_TESTS:
89-
# If set to any non-empty or non-0 value, will skip running
90-
# contrib/lite tests, but will leave other contrib tests.
9188
# TF_SKIP_CONTRIB_TESTS:
9289
# If set to any non-empty or non-0 value, will skip running
9390
# contrib tests.
@@ -134,7 +131,13 @@ BAZEL_CMD="bazel test"
134131
BAZEL_BUILD_ONLY_CMD="bazel build"
135132
BAZEL_CLEAN_CMD="bazel clean"
136133

137-
DEFAULT_BAZEL_CONFIGS=""
134+
# Default flags:
135+
# --test_summary=detailed: Tell us more about which targets are being built
136+
# --keep_going: Don't stop at the first failure; tell us all the failures
137+
# --build_tests_only: Don't build targets depended on by tests if the test is
138+
# disabled. Also saves some compilation time. Otherwise,
139+
# tries to build everything.
140+
DEFAULT_BAZEL_CONFIGS="--test_summary=detailed --build_tests_only --keep_going"
138141

139142
PIP_CMD="${CI_BUILD_DIR}/builds/pip.sh"
140143
PIP_TEST_TUTORIALS_FLAG="--test_tutorials"
@@ -150,10 +153,6 @@ BENCHMARK_CMD="${CI_BUILD_DIR}/builds/benchmark.sh"
150153
EXTRA_PARAMS=""
151154
BAZEL_TARGET="//tensorflow/... -//tensorflow/compiler/..."
152155

153-
if [[ -n "$TF_SKIP_LITE_TESTS" ]]; then
154-
BAZEL_TARGET="${BAZEL_TARGET} -//tensorflow/contrib/lite/..."
155-
fi
156-
157156
if [[ -n "$TF_SKIP_CONTRIB_TESTS" ]]; then
158157
BAZEL_TARGET="${BAZEL_TARGET} -//tensorflow/contrib/..."
159158
fi

0 commit comments

Comments
 (0)