Skip to content

Commit 1acf6fe

Browse files
authored
Merge pull request #21 from pklaschka/develop
v1.0.0
2 parents 222a1bf + 922de4e commit 1acf6fe

45 files changed

Lines changed: 2507 additions & 1105 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.eslintrc.js

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
module.exports = {
2+
"env": {
3+
"es6": true,
4+
"node": true,
5+
"commonjs": true,
6+
"browser": true,
7+
"jest": true
8+
},
9+
"extends": "eslint:recommended",
10+
"parserOptions": {
11+
"ecmaVersion": 2018
12+
},
13+
"rules": {
14+
"indent": [
15+
"error",
16+
4
17+
],
18+
"quotes": [
19+
"error",
20+
"single"
21+
],
22+
"semi": [
23+
"error",
24+
"always"
25+
],
26+
"no-console": "error",
27+
"valid-jsdoc": "error",
28+
"max-len": ["error", { "code": 120 }]
29+
}
30+
};

.npmignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,7 @@ tests
55
coverage
66
.travis.yml
77
.github
8+
src
9+
tsconfig.json
10+
webpack.config.js
11+
.eslintrc.js

.travis.yml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
11
language: node_js
22
node_js:
3-
- "node"
3+
- "node"
4+
5+
sudo: false
6+
7+
install:
8+
- npm install
9+
- npm install -g coveralls
10+
11+
script:
12+
- npm test
13+
- cat ./coverage/lcov.info | coveralls

LICENSE

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
MIT License
22

3-
Copyright (c) 2018 Pablo Klaschka
3+
Copyright (c) 2019 Pablo Klaschka
44

55
Permission is hereby granted, free of charge, to any person obtaining a copy
66
of this software and associated documentation files (the "Software"), to deal
@@ -18,4 +18,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
1818
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
1919
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
2020
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
21-
SOFTWARE.
21+
SOFTWARE.

README.md

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,3 +36,33 @@ const dialogHelper = require('./lib/dialog-helper');
3636

3737
#### Documentation for the library
3838
You can find a detailed guide on how to use the library in the [repository wiki](https://github.com/pklaschka/xd-dialog-helper/wiki).
39+
40+
### Migrating to v1.0.0
41+
Mostly, there should be no breaking changes (but many additional options and improvements) in v1.0, since it mostly consists of an internal restructuring.
42+
43+
However, with the release of the new version, the types have moved to a
44+
`types` namespace inside the `xd-dialog-helper` module.
45+
46+
This means that instead of writing
47+
48+
```js
49+
dialogHelper.showDialog('dialog', 'My dialog', [{
50+
id: 123,
51+
type: dialogHelper.TEXT_INPUT,
52+
label: 'Good morning'
53+
}]);
54+
```
55+
56+
we have to write:
57+
58+
```js
59+
dialogHelper.showDialog('dialog', 'My dialog', [{
60+
id: 123,
61+
type: dialogHelper.types.TEXT_INPUT,
62+
label: 'Good morning'
63+
}]);
64+
```
65+
66+
> **Please note:** The old way is still available (but marked as deprecated) in the alpha- and beta versions of v1.0. It will, however, get removed with the full release of the new version.
67+
68+
Also, the type constant previously were aliases for numeric constants representing the type. This is no longer the case (to support custom types), which is why numeric values are no longer possible for the `type` field.

0 commit comments

Comments
 (0)