Skip to content

Commit 2d4a466

Browse files
author
ivan.kapustin
committed
fix/request_error_details_dont_use_auth
1 parent 3faac40 commit 2d4a466

File tree

1 file changed

+19
-3
lines changed

1 file changed

+19
-3
lines changed

pycamunda/externaltask.py

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ class Get(pycamunda.base.CamundaRequest):
9797

9898
id_ = PathParameter('id')
9999

100-
def __init__(self, url: str, id_: str, request_error_details: bool = True):
100+
def __init__(self, url: str, id_: str, request_error_details: bool = False):
101101
"""Query for an external task.
102102
103103
:param url: Camunda Rest engine URL.
@@ -117,6 +117,14 @@ def __call__(self, *args, **kwargs) -> ExternalTask:
117117
if self.request_error_details:
118118
if external_task.error_details is None:
119119
try:
120+
_request = None
121+
request_data = {}
122+
if self.session is not None:
123+
_request = self.session
124+
else:
125+
_request = requests
126+
if self.auth is not None:
127+
request_data['auth'] = self.auth
120128
response = requests.get(self.url + '/errorDetails')
121129
except requests.exceptions.RequestException:
122130
raise pycamunda.PyCamundaException()
@@ -193,7 +201,7 @@ def __init__(
193201
ascending: bool = True,
194202
first_result: int = None,
195203
max_results: int = None,
196-
request_error_details: bool = True
204+
request_error_details: bool = False
197205
):
198206
"""Query for a list of external tasks using a list of parameters. The size of the result set
199207
can be retrieved by using the Get Count request.
@@ -266,7 +274,15 @@ def __call__(self, *args, **kwargs) -> typing.Tuple[ExternalTask]:
266274
for external_task in external_tasks:
267275
if external_task.error_details is None:
268276
try:
269-
response = requests.get(self.url + f'/{external_task.id_}/errorDetails')
277+
_request = None
278+
request_data = {}
279+
if self.session is not None:
280+
_request = self.session
281+
else:
282+
_request = requests
283+
if self.auth is not None:
284+
request_data['auth'] = self.auth
285+
response = _request.get(self.url + f'/{external_task.id_}/errorDetails', **request_data)
270286
except requests.exceptions.RequestException:
271287
raise pycamunda.PyCamundaException()
272288
if not response:

0 commit comments

Comments
 (0)