Skip to content

Commit 6979452

Browse files
committed
pkp/pkp-lib#4860 Separate VersionStage enum into OJS, OMP, OPS
1 parent 4fc4ceb commit 6979452

File tree

6 files changed

+49
-5
lines changed

6 files changed

+49
-5
lines changed

classes/components/forms/publication/PublishForm.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
use APP\publication\Publication;
2121
use PKP\components\forms\FieldHTML;
2222
use PKP\components\forms\FormComponent;
23-
use PKP\publication\enums\VersionStage;
2423

2524
class PublishForm extends FormComponent
2625
{
@@ -64,7 +63,7 @@ public function __construct($action, $publication, $submissionContext, $requirem
6463
$publicationVersion = $publication->getVersion();
6564
if (!isset($publicationVersion)) {
6665
$submission = Repo::submission()->get($publication->getData('submissionId'));
67-
$nextVersion = Repo::submission()->getNextAvailableVersion($submission, VersionStage::VERSION_OF_RECORD, false);
66+
$nextVersion = Repo::submission()->getNextAvailableVersion($submission, Publication::DEFAULT_VERSION_STAGE, false);
6867

6968
$msg .= '<p>' . __('publication.required.versionStage') . '</p>';
7069
$msg .= '<p>' . __('publication.required.versionStage.assignment', [

classes/migration/install/OPSMigration.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@
1414

1515
namespace APP\migration\install;
1616

17+
use APP\publication\enums\VersionStage;
1718
use Illuminate\Database\Schema\Blueprint;
1819
use Illuminate\Support\Facades\DB;
1920
use Illuminate\Support\Facades\Schema;
20-
use PKP\publication\enums\VersionStage;
2121

2222
class OPSMigration extends \PKP\migration\Migration
2323
{

classes/publication/Publication.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,13 @@
2020

2121
use APP\core\Application;
2222
use APP\file\PublicFileManager;
23+
use APP\publication\enums\VersionStage;
2324
use PKP\publication\PKPPublication;
2425

2526
class Publication extends PKPPublication
2627
{
28+
public const DEFAULT_VERSION_STAGE = VersionStage::AUTHOR_ORIGINAL;
29+
2730
public const PUBLICATION_RELATION_NONE = 1;
2831
public const PUBLICATION_RELATION_PUBLISHED = 3;
2932

classes/publication/Repository.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,14 @@
1515

1616
use APP\core\Application;
1717
use APP\facades\Repo;
18+
use APP\publication\enums\VersionStage;
1819
use APP\submission\Submission;
1920
use Illuminate\Support\Facades\App;
2021
use PKP\context\Context;
2122
use PKP\core\Core;
2223
use PKP\core\PKPString;
2324
use PKP\plugins\Hook;
2425
use PKP\publication\Collector;
25-
use PKP\publication\enums\VersionStage;
2626
use PKP\security\Role;
2727
use PKP\stageAssignment\StageAssignment;
2828
use PKP\user\User;
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
<?php
2+
3+
/**
4+
* @file publication/enums/VersionStage.php
5+
*
6+
* Copyright (c) 2023-2024 Simon Fraser University
7+
* Copyright (c) 2023-2024 John Willinsky
8+
* Distributed under the GNU GPL v3. For full terms see the file docs/COPYING.
9+
*
10+
* @class VersionStage
11+
*
12+
* @brief Enumeration for publication version stages
13+
*
14+
* see also https://www.niso.org/standards-committees/jav-revision
15+
*/
16+
17+
namespace APP\publication\enums;
18+
19+
enum VersionStage: string
20+
{
21+
case AUTHOR_ORIGINAL = 'AO';
22+
case SUBMITTED_MANUSCRIPT = 'SM';
23+
24+
public function labelKey(): string
25+
{
26+
return match ($this) {
27+
self::AUTHOR_ORIGINAL => 'publication.versionStage.authorOriginal',
28+
self::SUBMITTED_MANUSCRIPT => 'publication.versionStage.submittedManuscript',
29+
};
30+
}
31+
32+
public function label(?string $locale = null): string
33+
{
34+
return __($this->labelKey(), locale: $locale);
35+
}
36+
}

locale/en/submission.po

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,4 +244,10 @@ msgstr "Add any information that you think our moderators should know before pos
244244
msgid "submission.copyright.description"
245245
msgstr ""
246246
"Please read and understand the copyright terms for submissions to this "
247-
"preprint server."
247+
"preprint server."
248+
249+
msgid "publication.versionStage.authorOriginal"
250+
msgstr "Author Original"
251+
252+
msgid "publication.versionStage.submittedManuscript"
253+
msgstr "Submitted Manuscript"

0 commit comments

Comments
 (0)