#11390 Allow nullable reviewer recommendation at save for later

#11390 Allow nullable reviewer recommendation at save for later

Author: touhidurabir

classes/submission/reviewer/form/PKPReviewerReviewStep3Form.php

@@ -285,7 +285,10 @@ public function saveForLater()
 
         // Persist the updated review assignment.
         Repo::reviewAssignment()->edit($reviewAssignment, [
-            'reviewerRecommendationId' => (int) $this->getData('reviewerRecommendationId'), // save the recommendation to the review assignment
+            // save the recommendation to the review assignment
+            'reviewerRecommendationId' => (int)$this->getData('reviewerRecommendationId') === 0
+                ? null
+                : (int)$this->getData('reviewerRecommendationId'),
         ]);
 
         return true;

js/controllers/form/reviewer/ReviewerReviewStep3FormHandler.js

@@ -66,7 +66,7 @@
 			prototype.updateRecommendationRequired_ = function(submitButton, event) {
 
 		var $formElement = this.getHtmlElement(),
-				$recommendationElement = $formElement.find('[id^="recommendation"]');
+				$recommendationElement = $formElement.find('[id^="reviewerRecommendationId"]');
 		if ($recommendationElement.length) {
 			if (submitButton.id.includes('submitFormButton-')) {
 				$recommendationElement.attr('required', '1');