Fix XML responses being served with JSON []

asmecher · asmecher · commit 5505c2516eaa · 2025-03-27T11:50:40.000-07:00
diff --git a/api/v1/reviews/PKPReviewController.php b/api/v1/reviews/PKPReviewController.php
@@ -722,7 +722,7 @@ public function exportReviewXML(Request $illuminateRequest): JsonResponse
     /**
      * Download exported review file from temporary file ID
      */
-    public function getExportedFile(Request $illuminateRequest): JsonResponse
+    public function getExportedFile(Request $illuminateRequest): Response
     {
         $fileId = (int) $illuminateRequest->route('fileId');
         $currentUser = Application::get()->getRequest()->getUser();
@@ -734,7 +734,7 @@ public function getExportedFile(Request $illuminateRequest): JsonResponse
                 'error' => __('api.403.unauthorized'),
             ], Response::HTTP_FORBIDDEN);
         }
-        return response()->json([], Response::HTTP_OK);
+        return response()->noContent(Response::HTTP_OK);//json([], Response::HTTP_OK);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -722,7 +722,7 @@ public function exportReviewXML(Request $illuminateRequest): JsonResponse`
`722`	`722`	`/**`
`723`	`723`	`* Download exported review file from temporary file ID`
`724`	`724`	`*/`
`725`		`- public function getExportedFile(Request $illuminateRequest): JsonResponse`
	`725`	`+ public function getExportedFile(Request $illuminateRequest): Response`
`726`	`726`	`{`
`727`	`727`	`$fileId = (int) $illuminateRequest->route('fileId');`
`728`	`728`	`$currentUser = Application::get()->getRequest()->getUser();`
`@@ -734,7 +734,7 @@ public function getExportedFile(Request $illuminateRequest): JsonResponse`
`734`	`734`	`'error' => __('api.403.unauthorized'),`
`735`	`735`	`], Response::HTTP_FORBIDDEN);`
`736`	`736`	`}`
`737`		`- return response()->json([], Response::HTTP_OK);`
	`737`	`+ return response()->noContent(Response::HTTP_OK);//json([], Response::HTTP_OK);`
`738`	`738`	`}`
`739`	`739`
`740`	`740`	`/**`