Merge pull request #11386 from Hafsa-Naeem/i10263-stable_3_5_0-cleanup

#10263 Follow-up to clean up canEditPublication method per review feedback from PR#11225

Author: Vitaliy-1

classes/submission/Repository.php

@@ -520,16 +520,16 @@ public function canEditPublication(int $submissionId, int $userId): bool
 
         $submission = $this->get($submissionId);
         // any published or scheduled then probe
-        $hasLockedPublication = $submission
-            && $submission->getData('publications')
-                ->contains(fn($p) =>
+        $hasLockedPublication = $submission?->getData('publications')
+            ->contains(
+                fn (Publication $p) =>
                     in_array(
                         $p->getData('status'),
                         [Submission::STATUS_PUBLISHED, Submission::STATUS_SCHEDULED]
                     )
-                );
+            );
 
-        if ($hasLockedPublication && !$assignments->contains(fn($sa) => $sa->userGroup && $sa->userGroup->roleId !== Role::ROLE_ID_AUTHOR)) {
+        if ($hasLockedPublication && !$assignments->contains(fn (StageAssignment $sa) => $sa->userGroup && $sa->userGroup->roleId != Role::ROLE_ID_AUTHOR)) {
             return false;
         }