Description
Valid Title
- I have updated the title to accurately reflect the bug description
Description
Actually our e2e tests do this automatically with the Kumiega submission #13 \cypress\tests\data\60-content\LkumiegaSubmission.cy.js . I didn't know there was a difference in confirming a review with the editor manually or having the system automatically confirm and thank the reviewer. I was wrong. If you request revisions you can inform the reviewers in an email and this will trigger the reviewer states to say thank you. This will not have a date passed through and will break the confirmation dialogue box in the editorial activity.
Preconditions:
- If you are checking locally with latest dataset this is easy to find by logging in as an editor and clicking on the confirmed status of a reviewer in the submission list for ID number 13. The date will be missing.
- If you are wanting to start from a fresh submission that is already in review stage with reviewers added then I will write those steps down below.
Steps to Reproduce
- Login with JM or JE role
- Navigate to the appropriate submission in the review stage
- For each reviewer login as this reviewer in the list and complete the review
- Logout as the last reviewer or log back in as the JM or JE role
- Navigate to the appropriate submission again
- Select Request Revisions from the action
- Select the option "Revisions will not be subject to a new round of peer reviews" and select Next button
- Select Continue on the notify authors email page
- Select Record Decision to notify the reviewers (This is what triggers the automatic thanking and confirming the reviews which doesn't have date)
Expected Result
The decision should be recorded and the reviewers thanked and the editorial activity in the submission should have the green checkmark icon. When selecting this icon it should have the message "The review was accepted by the editor on {confirmed date}".
Actual Result
When selecting the green check icon for in editorial activity it is missing the date and the message in the dialogue box reads "The review was accepted by the editor on ."
Environment Details
No response
Application Version
OJS, OMP, OPS 3.5.0rc2
Logs
No response
Additional Information
This also affects the submission views ability to sort correctly. The Need Reviews view will not correctly identify that the automatically confirmed reviews meet the threshold for minimum required reviews setting. @jardakotesovec I could created an extra bug for this but I think the root cause fix will also fix this problem too.
