Chinese translation displays authors name in the wrong order

[pmangahis]

A hosted client has pointed out that when an OJS user uses a Chinese language locale (Simplified or Traditional) the way the names are displayed appears in the wrong order, which I had confirmed by a Chinese reader.

Currently, names in both English and Chinese show up as First, Last Name. But the proper way to display a Chinese the names should appear Last Name, First name.

For example, the proper way to display David Chau in Chinese would need to be Chau (周) David ( 國豪) = 周 國豪.

I had tested this in OJS 3.2.1-2. and the name appears in the wrong order (still in exact first, Last name order).

[asmecher]

The way full names are built from family and given names is implemented in Identity::getFullName. There are two forms: conventional, and last name first (e.g. Alec Smecher and Smecher, Alec).

I'd recommend introducing two new locale keys so that the construction can be done on a locale-by-locale basis. For example, a new locale key user.name.conventional could map to {$givenName} {$familyName}, and a new locale key user.name.lastFirst could map to {$familyName}, {$givenName}. The getFullName function could be modified to use these, and defaults could be added for all current languages except Chinese. (Are there others we already support that need consideration?)

[NateWr]

Are there others we already support that need consideration?

Perhaps we can mark all of the other translations with the fuzzy flag so that translators will review them?

[emmauhl]

Just jumping in to add that after the development of the Traditional Chinese translation by HKBU, this has been brought up again as an important need. Per Alec's question, I also wanted to expand the request to Korean, Japanese, Vietnamese & Hungarian - these languages are in our Weblate instance that have this same convention.

[asmecher]

Related forum thread: https://forum.pkp.sfu.ca/t/how-to-change-familyfirst-tag-in-edit-user/95205/2