Merge pull request #7 from placemark/json-errors

Handle JSON errors
placemark · Jun 26, 2021 · e64d3ce · e64d3ce
2 parents 9e6363b + 6f408ab
commit e64d3ce
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 14 deletions.
diff --git a/src/errors.ts b/src/errors.ts
@@ -14,7 +14,12 @@ interface HintIssueType extends HintIssueBase {
   code: 'invalid_type';
 }
 
-export type HintIssue = HintIssueRootType | HintIssueType;
+interface HintJSONIssue {
+  code: 'invalid_json';
+  line: number;
+}
+
+export type HintIssue = HintIssueRootType | HintIssueType | HintJSONIssue;
 
 export class HintError extends Error {
   issues: HintIssue[] = [];

diff --git a/src/index.ts b/src/index.ts
@@ -168,19 +168,8 @@ export const check = (jsonStr: string): GeoJSON => {
     });
   } catch (e) {
     issues.push({
-      code: 'invalid_type',
-      loc: {
-        start: {
-          line: e.line,
-          column: e.column,
-          offset: 0,
-        },
-        end: {
-          line: e.line,
-          column: e.column,
-          offset: 0,
-        },
-      },
+      code: 'invalid_json',
+      line: e.line,
     });
   }
   if (ast) checkObject(issues, ast.body);

diff --git a/test/bad.test.ts b/test/bad.test.ts
@@ -40,6 +40,22 @@ describe('check', () => {
     ).toThrow(HintError);
   });
 
+  it('bad json', () => {
+    try {
+      check(
+        `{
+    "type": "MultiPoint"
+    "coordinates": [["foo", "bar"]]
+}`
+      );
+    } catch (e) {
+      expect(e.issues[0]).toEqual({
+        code: 'invalid_json',
+        line: 3,
+      });
+    }
+  });
+
   describe('works with fixtures', () => {
     const fixtureNames = readdirSync(Path.join(__dirname, './fixture/bad/'));
     for (let name of fixtureNames) {