Fix event frequency condition to sum counts instead of counting buckets (#74)

Author: VictorB00

nubrick/src/androidTest/kotlin/app/nubrick/nubrick/data/database/database.kt

@@ -1,11 +1,46 @@
 package app.nubrick.nubrick.data.database
 
+import android.database.sqlite.SQLiteDatabase
+import app.nubrick.nubrick.schema.ConditionOperator
+import app.nubrick.nubrick.schema.FrequencyUnit
+import app.nubrick.nubrick.schema.UserEventFrequencyCondition
 import org.junit.Assert
+import org.junit.After
+import org.junit.Before
 import org.junit.Test
 
-class ExampleUnitTest {
+class DatabaseRepositoryAndroidTest {
+    private lateinit var db: SQLiteDatabase
+    private lateinit var repository: DatabaseRepositoryImpl
+
+    @Before
+    fun setUp() {
+        db = SQLiteDatabase.create(null)
+        db.execSQL(SQL_CREATE_EXPERIMENT_HISTORY_TABLE)
+        db.execSQL(SQL_CREATE_USER_EVENT_TABLE)
+        repository = DatabaseRepositoryImpl(db)
+    }
+
+    @After
+    fun tearDown() {
+        db.close()
+    }
+
     @Test
-    fun addition_isCorrect() {
-        Assert.assertEquals(4, 2 + 2)
+    fun eventFrequencyConditionCountsEventsInSameBucket() {
+        repository.appendUserEvent("purchase")
+        repository.appendUserEvent("purchase")
+
+        val matched = repository.isMatchedToUserEventFrequencyCondition(
+            UserEventFrequencyCondition(
+                eventName = "purchase",
+                lookbackPeriod = 1,
+                unit = FrequencyUnit.DAY,
+                comparison = ConditionOperator.GreaterThanOrEqual,
+                threshold = 2,
+            )
+        )
+
+        Assert.assertTrue(matched)
     }
 }

nubrick/src/main/kotlin/app/nubrick/nubrick/data/database/database.kt

@@ -78,7 +78,7 @@ internal class DatabaseRepositoryImpl(private val db: SQLiteDatabase): DatabaseR
             lookbackPeriod = condition.lookbackPeriod,
             since = condition.since
         )
-        val total = counts.values.count()
+        val total = counts.values.sum()
         return compareInteger(total, listOf(threshold), comparison)
     }
-}
+}