[TASK] Move cms-install and cms-scheduler to suggest + require-dev

The wizard class and Task wrapper load lazily — when their respective
TYPO3 packages aren't installed, nothing autoloads them. Guard the
scheduler-task registration in ext_localconf.php with class_exists
for explicit clarity.

Author: wazum

Classes/Command/ProcessWebpQueueCommand.php

@@ -11,7 +11,6 @@
 use Plan2net\Webp\Service\FolderScanner;
 use Plan2net\Webp\Service\ProcessedFileWriter;
 use Plan2net\Webp\Service\Webp as WebpService;
-use Plan2net\Webp\Task\ProcessWebpQueueTask;
 use Psr\Log\LoggerAwareInterface;
 use Psr\Log\LoggerAwareTrait;
 use Symfony\Component\Console\Attribute\AsCommand;
@@ -52,7 +51,10 @@ public function __construct(
 
     protected function configure(): void
     {
-        $this->addOption('batch', null, InputOption::VALUE_REQUIRED, 'Maximum number of queue entries to process per run', (string) ProcessWebpQueueTask::DEFAULT_BATCH_SIZE);
+        // Inline default mirrors ProcessWebpQueueTask::DEFAULT_BATCH_SIZE.
+        // Not a class-constant reference because the command must work even when
+        // typo3/cms-scheduler is absent (the Task class extends AbstractTask).
+        $this->addOption('batch', null, InputOption::VALUE_REQUIRED, 'Maximum number of queue entries to process per run', '50');
         $this->addOption('folder', null, InputOption::VALUE_REQUIRED, 'Filesystem folder to sweep (relative to public web root). When set, bypasses the queue.');
     }
 

Classes/Updates/TruncateFailedAttemptsBeforeColumnResizeUpdate.php

@@ -4,9 +4,9 @@
 
 namespace Plan2net\Webp\Updates;
 
+use TYPO3\CMS\Core\Attribute\UpgradeWizard;
 use TYPO3\CMS\Core\Database\ConnectionPool;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
-use TYPO3\CMS\Install\Attribute\UpgradeWizard;
 use TYPO3\CMS\Install\Updates\UpgradeWizardInterface;
 
 #[UpgradeWizard('webp.truncateFailedAttemptsBeforeColumnResize')]

Configuration/Services.php

@@ -0,0 +1,32 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Plan2net\Webp;
+
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+use TYPO3\CMS\Install\Updates\UpgradeWizardInterface;
+use TYPO3\CMS\Scheduler\AbstractAdditionalFieldProvider;
+
+return static function (ContainerConfigurator $configurator): void {
+    $services = $configurator->services();
+
+    // Service classes that extend or implement types from TYPO3 packages we
+    // treat as soft dependencies. Register only when the respective package
+    // is installed; otherwise loading the file would fatal at the
+    // extends/implements clause.
+
+    if (\interface_exists(UpgradeWizardInterface::class)) {
+        $services
+            ->set(Updates\TruncateFailedAttemptsBeforeColumnResizeUpdate::class)
+            ->autowire()
+            ->tag('install.upgradewizard', ['identifier' => 'webp.truncateFailedAttemptsBeforeColumnResize']);
+    }
+
+    if (\class_exists(AbstractAdditionalFieldProvider::class)) {
+        $services
+            ->set(Task\ProcessWebpQueueTaskAdditionalFieldProvider::class)
+            ->autowire()
+            ->public();
+    }
+};

Configuration/Services.yaml

@@ -54,11 +54,6 @@ services:
     tags:
       - name: 'console.command'
 
-  Plan2net\Webp\Task\ProcessWebpQueueTaskAdditionalFieldProvider:
-    public: true
-
-  Plan2net\Webp\Updates\TruncateFailedAttemptsBeforeColumnResizeUpdate: ~
-
   # public: true required so GeneralUtility::makeInstance(Configuration::class) resolves
   # the service from the container (called from FileNameFilter::filterWebpFiles and from
   # ext_localconf.php — neither has a DI constructor injection point).

composer.json

@@ -30,12 +30,12 @@
   "require": {
     "php": ">=8.2",
     "symfony/finder": "^6.4 || ^7.0",
-    "typo3/cms-core": "^12.4 || ^13.4 || ^14.0",
-    "typo3/cms-install": "^12.4 || ^13.4 || ^14.0",
-    "typo3/cms-scheduler": "^12.4 || ^13.4 || ^14.0"
+    "typo3/cms-core": "^12.4 || ^13.4 || ^14.0"
   },
   "suggest": {
-    "ext-gd": "Use GD for image processing"
+    "ext-gd": "Use GD for image processing",
+    "typo3/cms-install": "Required only if you run the UpgradeWizard that clears legacy tx_webp_failed rows during a configuration_hash column resize",
+    "typo3/cms-scheduler": "Required only when async = 1; provides the scheduler task that drains tx_webp_queue out-of-band"
   },
   "autoload": {
     "psr-4": {
@@ -60,6 +60,8 @@
   },
   "require-dev": {
     "phpunit/phpunit": "^10.5 || ^11",
+    "typo3/cms-install": "^12.4 || ^13.4 || ^14.0",
+    "typo3/cms-scheduler": "^12.4 || ^13.4 || ^14.0",
     "typo3/testing-framework": "^8.0 || ^9.0",
     "friendsofphp/php-cs-fixer": "^3.75"
   }

ext_localconf.php

@@ -13,11 +13,17 @@
         ];
     }
 
-    $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['scheduler']['tasks'][Plan2net\Webp\Task\ProcessWebpQueueTask::class] = [
-        'extension' => 'webp',
-        'title' => 'LLL:EXT:webp/Resources/Private/Language/locallang.xlf:task.processQueue.title',
-        'description' => 'LLL:EXT:webp/Resources/Private/Language/locallang.xlf:task.processQueue.description',
-        'icon' => 'mimetypes-x-tx_scheduler_task_group',
-        'additionalFields' => Plan2net\Webp\Task\ProcessWebpQueueTaskAdditionalFieldProvider::class,
-    ];
+    // Register the scheduler task only when cms-scheduler is installed.
+    // Both cms-scheduler and cms-install are soft dependencies of this extension;
+    // the task wrapper class and the upgrade wizard load lazily so missing
+    // packages don't fatal at boot.
+    if (\class_exists(TYPO3\CMS\Scheduler\Task\AbstractTask::class)) {
+        $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['scheduler']['tasks'][Plan2net\Webp\Task\ProcessWebpQueueTask::class] = [
+            'extension' => 'webp',
+            'title' => 'LLL:EXT:webp/Resources/Private/Language/locallang.xlf:task.processQueue.title',
+            'description' => 'LLL:EXT:webp/Resources/Private/Language/locallang.xlf:task.processQueue.description',
+            'icon' => 'mimetypes-x-tx_scheduler_task_group',
+            'additionalFields' => Plan2net\Webp\Task\ProcessWebpQueueTaskAdditionalFieldProvider::class,
+        ];
+    }
 })();