[TASK] Apply cs-fixer cleanup to async queue files

Author: wazum

Classes/Command/ProcessWebpQueueCommand.php

@@ -71,13 +71,15 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         }
         if (!$acquired) {
             $output->writeln('<info>Another webp:process-queue is running; exiting.</info>');
+
             return Command::SUCCESS;
         }
         try {
             $folder = $input->getOption('folder');
-            if (\is_string($folder) && $folder !== '') {
+            if (\is_string($folder) && '' !== $folder) {
                 return $this->runFolderMode($folder, $output);
             }
+
             return $this->runQueueMode(\max(1, (int) $input->getOption('batch')), $output);
         } finally {
             $locker->release();
@@ -96,7 +98,7 @@ private function runQueueMode(int $batch, OutputInterface $output): int
                 $originalFile = $this->resourceFactory->getFileObject($entry->originalFileId);
                 $configuration = (array) \unserialize($entry->configuration, ['allowed_classes' => false]);
                 $source = $this->resolveSource($entry->processedFileId, $originalFile);
-                if ($source === null) {
+                if (null === $source) {
                     continue;
                 }
                 $processedFileWebp = $this->processedFileRepository->findOneByOriginalFileAndTaskTypeAndConfiguration(
@@ -131,14 +133,16 @@ private function runQueueMode(int $batch, OutputInterface $output): int
                 $this->applyThrottle($throttleMs, $index === $lastIndex);
             }
         }
+
         return Command::SUCCESS;
     }
 
     private function runFolderMode(string $folder, OutputInterface $output): int
     {
         $rootPath = $this->resolveAgainstWebRoot($folder);
-        if ($rootPath === null) {
+        if (null === $rootPath) {
             $output->writeln(\sprintf('<error>Folder "%s" not found or outside the public web root</error>', $folder));
+
             return Command::FAILURE;
         }
 
@@ -155,6 +159,7 @@ private function runFolderMode(string $folder, OutputInterface $output): int
             }
             $this->applyThrottle($throttleMs, $index === $lastIndex);
         }
+
         return Command::SUCCESS;
     }
 
@@ -163,7 +168,7 @@ private function resolveSource(int $processedFileId, $originalFile): ?\TYPO3\CMS
         if (!$originalFile instanceof \TYPO3\CMS\Core\Resource\FileInterface) {
             return null;
         }
-        if ($processedFileId === 0) {
+        if (0 === $processedFileId) {
             return $originalFile;
         }
         try {
@@ -176,7 +181,7 @@ private function resolveSource(int $processedFileId, $originalFile): ?\TYPO3\CMS
     private function resolveAgainstWebRoot(string $folder): ?string
     {
         $webRoot = \realpath(Environment::getPublicPath());
-        if ($webRoot === false) {
+        if (false === $webRoot) {
             return null;
         }
         $candidate = \realpath($webRoot . '/' . \ltrim($folder, '/'));

Classes/EventListener/AfterFileProcessing.php

@@ -103,6 +103,7 @@ private function processFile(
                         $taskType,
                         $configuration + ['webp' => true]
                     );
+
                     return;
                 } catch (\Doctrine\DBAL\Exception $e) {
                     $this->logger->notice(

Classes/Task/ProcessWebpQueueTask.php

@@ -20,6 +20,7 @@ public function execute(): bool
     {
         $command = GeneralUtility::makeInstance(ProcessWebpQueueCommand::class);
         $input = new ArrayInput(['--batch' => (string) $this->batchSize]);
+
         return 0 === $command->run($input, new NullOutput());
     }
 }

Tests/Functional/Command/ProcessWebpQueueCommandTest.php

@@ -190,6 +190,7 @@ protected function setUp(): void
     private function runCommand(array $arguments): int
     {
         $tester = new CommandTester($this->get(ProcessWebpQueueCommand::class));
+
         return $tester->execute($arguments);
     }
 

Tests/Functional/Domain/Queue/WebpQueueRepositoryTest.php

@@ -149,6 +149,6 @@ private function fetchEnqueuedAt(int $originalFileId): int
             ->select(['enqueued_at'], 'tx_webp_queue', ['original_file_id' => $originalFileId])
             ->fetchAssociative();
 
-        return $row !== false ? (int) $row['enqueued_at'] : 0;
+        return false !== $row ? (int) $row['enqueued_at'] : 0;
     }
 }

Tests/Unit/Service/FolderScannerTest.php

@@ -122,12 +122,13 @@ private function removeRecursive(string $path): void
         }
         if (\is_dir($path)) {
             foreach (\scandir($path) ?: [] as $entry) {
-                if ($entry === '.' || $entry === '..') {
+                if ('.' === $entry || '..' === $entry) {
                     continue;
                 }
                 $this->removeRecursive($path . '/' . $entry);
             }
             \rmdir($path);
+
             return;
         }
         \unlink($path);