Mocking hangfire

Author: Atralupus

Mimir.Initializer/Migrators/ProductMigrator.cs

@@ -63,7 +63,7 @@ public async Task RunAsync(CancellationToken stoppingToken)
 
             int? crystal = null;
             int? crystalPerPrice = null;
-            int? combatPoint = null;
+            long? combatPoint = null;
             try
             {
                 (crystal, crystalPerPrice) = await _itemProductCalculationService.CalculateCrystalMetricsAsync(itemProduct);

Mimir.MongoDB/Bson/ProductDocument.cs

@@ -10,7 +10,7 @@ public record ProductDocument : MimirBsonDocument
     public Address AvatarAddress { get; init; }
     public Address ProductsStateAddress { get; init; }
     public Product Object { get; init; }
-    public int? CombatPoint { get; init; }
+    public long? CombatPoint { get; init; }
     public decimal? UnitPrice { get; init; }
     public int? Crystal { get; init; }
     public int? CrystalPerPrice { get; init; }
@@ -36,7 +36,7 @@ public ProductDocument(
         Address productsStateAddress,
         Product product,
         decimal unitPrice,
-        int? combatPoint,
+        long? combatPoint,
         int? crystal,
         int? crystalPerPrice
     )

Mimir.Tests/QueryTests/AgentTest.cs

@@ -2,6 +2,7 @@
 using Libplanet.Crypto;
 using Mimir.MongoDB.Bson;
 using Mimir.MongoDB.Repositories;
+using Mimir.Services;
 using Moq;
 using Nekoyume;
 

Mimir.Tests/QueryTests/BalanceQueryTest.cs

@@ -61,32 +61,6 @@ public async Task GraphQL_Query_Balance_NCG_Returns_CorrectValue()
         await Verify(result);
     }
 
-    [Fact]
-    public async Task GraphQL_Query_Balance_NCG_Enqueues_Recovery_When_Not_Found()
-    {
-        var mockAddress = new Address("0x0000000000000000000000000000000000000000");
-        var mockRepo = new Mock<IBalanceRepository>();
-        var mockStateRecoveryService = new Mock<IStateRecoveryService>();
-
-        mockRepo
-            .Setup(repo => repo.GetByAddressAsync("NCG".ToCurrency(), mockAddress))
-            .ThrowsAsync(new DocumentNotFoundInMongoCollectionException("balance_ncg", mockAddress.ToHex()));
-
-        var serviceProvider = TestServices.Builder
-            .With(mockRepo.Object)
-            .With(mockStateRecoveryService.Object)
-            .Build();
-
-        var query = $$"""
-                          query {
-                            balance(currencyTicker: "NCG", address: "{{mockAddress}}")
-                          }
-                      """;
-
-        var result = await TestServices.ExecuteRequestAsync(serviceProvider, b => b.SetDocument(query));
-        await Verify(result);
-    }
-    
     [Fact]
     public async Task GraphQL_Query_Balance_Throws_When_No_Inputs_Provided()
     {

Mimir.Tests/TestServices.cs

@@ -1,5 +1,7 @@
+using System.Linq.Expressions;
 using System.Numerics;
 using System.Security.Cryptography;
+using Hangfire;
 using HotChocolate;
 using HotChocolate.Execution;
 using Lib9c.GraphQL.Types;
@@ -10,6 +12,7 @@
 using Mimir.MongoDB.Bson;
 using Mimir.MongoDB.Repositories;
 using Mimir.MongoDB.Services;
+using Mimir.Services;
 using MongoDB.Driver;
 using Moq;
 
@@ -32,9 +35,13 @@ public ServiceProviderBuilder()
                 .BindRuntimeType(typeof(Address), typeof(AddressType))
                 .BindRuntimeType(typeof(BigInteger), typeof(BigIntegerType))
                 .BindRuntimeType(typeof(HashDigest<SHA256>), typeof(HashDigestSHA256Type));
+
+            var mockClient = new Mock<IBackgroundJobClient>();
+            _serviceCollection.AddSingleton<IBackgroundJobClient>(mockClient.Object);
         }
 
-        public ServiceProviderBuilder With<T>(T service) where T : class
+        public ServiceProviderBuilder With<T>(T service)
+            where T : class
         {
             _serviceCollection.AddSingleton(service);
             return this;
@@ -58,7 +65,8 @@ public IServiceProvider Build()
     public static async Task<string> ExecuteRequestAsync(
         IServiceProvider serviceProvider,
         Action<OperationRequestBuilder> configureRequest,
-        CancellationToken cancellationToken = default)
+        CancellationToken cancellationToken = default
+    )
     {
         await using var scope = serviceProvider.CreateAsyncScope();
 
@@ -67,8 +75,8 @@ public static async Task<string> ExecuteRequestAsync(
         configureRequest(requestBuilder);
         var request = requestBuilder.Build();
 
-        var executor = await scope.ServiceProvider
-            .GetRequiredService<IRequestExecutorResolver>()
+        var executor = await scope
+            .ServiceProvider.GetRequiredService<IRequestExecutorResolver>()
             .GetRequestExecutorAsync(cancellationToken: cancellationToken);
         await using var result = await executor.ExecuteAsync(request, cancellationToken);
         result.ExpectOperationResult();

Mimir.Worker/ActionHandler/ProductStateHandler.cs

@@ -203,7 +203,7 @@ Product product
 
                 int? crystal = null;
                 int? crystalPerPrice = null;
-                int? combatPoint = null;
+                long? combatPoint = null;
                 try
                 {
                     (crystal, crystalPerPrice) = await itemProductCalculationService.CalculateCrystalMetricsAsync(itemProduct);

Mimir.Worker/Services/IItemProductCalculationService.cs

@@ -7,7 +7,7 @@ namespace Mimir.Worker.Services;
 
 public interface IItemProductCalculationService
 {
-    Task<int?> CalculateCombatPointAsync(ItemProduct itemProduct);
+    Task<long?> CalculateCombatPointAsync(ItemProduct itemProduct);
 
     Task<(int? crystal, int? crystalPerPrice)> CalculateCrystalMetricsAsync(ItemProduct itemProduct);
 }

Mimir.Worker/Services/ItemProductCalculationService.cs

@@ -23,13 +23,13 @@ public ItemProductCalculationService(IMongoDbService store)
         _store = store;
     }
 
-    public async Task<int?> CalculateCombatPointAsync(ItemProduct itemProduct)
+    public async Task<long?> CalculateCombatPointAsync(ItemProduct itemProduct)
     {
         var costumeStatSheet = await _store.GetSheetAsync<CostumeStatSheet>();
 
         if (costumeStatSheet != null)
         {
-            int? cp = itemProduct.TradableItem switch
+            long? cp = itemProduct.TradableItem switch
             {
                 ItemUsable itemUsable => CPHelper.GetCP(
                     (Nekoyume.Model.Item.ItemUsable)

Mimir/GraphQL/Queries/Query.cs

@@ -1,3 +1,4 @@
+using Hangfire;
 using HotChocolate.AspNetCore;
 using Lib9c.GraphQL.Extensions;
 using Lib9c.GraphQL.InputObjects;
@@ -46,21 +47,29 @@ [Service] IActionTypeRepository repo
     /// </summary>
     /// <param name="address">The address of the agent.</param>
     /// <returns>The agent state</returns>
-    public async Task<AgentState> GetAgentAsync(Address address, [Service] IAgentRepository repo)
+    public async Task<AgentState> GetAgentAsync(
+        Address address,
+        [Service] IAgentRepository repo,
+        [Service] IBackgroundJobClient jobClient
+    )
     {
         try
         {
             var document = await repo.GetByAddressAsync(address);
             if (document.Metadata.StoredBlockIndex != 0)
             {
-                HangfireJobs.EnqueueAgentStateRecovery(address);
+                jobClient.Enqueue<IStateRecoveryService>(service =>
+                    service.TryRecoverAgentStateAsync(address)
+                );
             }
 
             return document.Object;
         }
         catch (Mimir.MongoDB.Exceptions.DocumentNotFoundInMongoCollectionException)
         {
-            HangfireJobs.EnqueueAgentStateRecovery(address);
+            jobClient.Enqueue<IStateRecoveryService>(service =>
+                service.TryRecoverAgentStateAsync(address)
+            );
             throw;
         }
     }
@@ -70,15 +79,21 @@ public async Task<AgentState> GetAgentAsync(Address address, [Service] IAgentRep
     /// </summary>
     /// <param name="address">The address of the avatar.</param>
     /// <returns>The avatar state</returns>
-    public async Task<AvatarState> GetAvatarAsync(Address address, [Service] IAvatarRepository repo)
+    public async Task<AvatarState> GetAvatarAsync(
+        Address address,
+        [Service] IAvatarRepository repo,
+        [Service] IBackgroundJobClient jobClient
+    )
     {
         try
         {
             return (await repo.GetByAddressAsync(address)).Object;
         }
         catch (Mimir.MongoDB.Exceptions.DocumentNotFoundInMongoCollectionException)
         {
-            HangfireJobs.EnqueueAvatarStateRecovery(address);
+            jobClient.Enqueue<IStateRecoveryService>(service =>
+                service.TryRecoverAvatarStateAsync(address)
+            );
             throw;
         }
     }
@@ -95,7 +110,8 @@ public async Task<string> GetBalanceAsync(
         CurrencyInput? currency,
         string? currencyTicker,
         Address address,
-        [Service] IBalanceRepository repo
+        [Service] IBalanceRepository repo,
+        [Service] IBackgroundJobClient jobClient
     )
     {
         try
@@ -118,7 +134,9 @@ [Service] IBalanceRepository repo
         {
             if (currencyTicker?.ToUpper() == "NCG")
             {
-                HangfireJobs.EnqueueNCGBalanceRecovery(address);
+                jobClient.Enqueue<IStateRecoveryService>(service =>
+                    service.TryRecoverNCGBalanceAsync(address)
+                );
             }
             throw;
         }

Mimir/Options/HangfireOption.cs

@@ -4,7 +4,6 @@ public class HangfireOption
 {
     public const string SectionName = "Hangfire";
 
-    public bool IsEnabled { get; set; } = false;
     public string RedisConnectionString { get; set; } = string.Empty;
     public string DashboardPath { get; set; } = "/hangfire";
     public int WorkerCount { get; set; } = Environment.ProcessorCount;