Add rustfmt and clippy CI gate on pinned 1.84.0 and make the crate rustfmt-clean

Author: dcadenas

.github/workflows/rust.yml

@@ -23,6 +23,33 @@ jobs:
           command: test
           args: --all-features --features ci
 
+  lint:
+    name: Rustfmt and Clippy
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install pinned toolchain with rustfmt and clippy
+        uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: 1.84.0
+          override: true
+          components: rustfmt, clippy
+
+      - name: Check formatting
+        uses: actions-rs/cargo@v1
+        with:
+          command: fmt
+          args: --all -- --check
+
+      - name: Clippy
+        uses: actions-rs/cargo@v1
+        with:
+          command: clippy
+          args: --all-targets --all-features -- -D warnings
+
   coverage:
     name: Code Coverage
     runs-on: ubuntu-latest

src/domain/followee_notification_factory.rs

@@ -109,9 +109,9 @@ impl FolloweeNotificationFactory {
     pub fn should_delete(&mut self) -> bool {
         // If it has been empty for a day, it's ok to delete
         self.follow_changes.is_empty()
-            && self.emptied_at.is_none_or(|emptied_at| {
-                Instant::now().duration_since(emptied_at) >= ONE_DAY
-            })
+            && self
+                .emptied_at
+                .is_none_or(|emptied_at| Instant::now().duration_since(emptied_at) >= ONE_DAY)
     }
 
     pub fn no_followers(&self) -> bool {
@@ -171,20 +171,14 @@ impl FolloweeNotificationFactory {
         }
 
         // Check if we need to remove any follow changes
-        let to_remove = self
-            .follow_changes
-            .len()
-            .saturating_sub(self.max_changes);
+        let to_remove = self.follow_changes.len().saturating_sub(self.max_changes);
         if to_remove > 0 {
             // First, remove all untrusted follow changes by retaining only trusted ones
             self.follow_changes
                 .retain(|_, follow_change| follow_change.is_trusted());
 
             // If we still need to remove more to stay under the limit, drain from the beginning (oldest entries)
-            let remaining_to_remove = self
-                .follow_changes
-                .len()
-                .saturating_sub(self.max_changes);
+            let remaining_to_remove = self.follow_changes.len().saturating_sub(self.max_changes);
             if remaining_to_remove > 0 {
                 // OrderMap preserves insertion order, so the first items are the oldest
                 self.follow_changes.drain(0..remaining_to_remove);

src/domain/notification_factory.rs

@@ -609,8 +609,7 @@ mod tests {
         // Insert trusted changes exceeding the max
         for _ in 0..max_changes + 3 {
             let follower = Keys::generate().public_key();
-            let change =
-                FollowChange::new_followed(*NOW, follower, followee).with_trusted(true);
+            let change = FollowChange::new_followed(*NOW, follower, followee).with_trusted(true);
             factory.insert(change.into());
         }
         assert_eq!(factory.follow_changes_len(), max_changes + 3);
@@ -644,8 +643,7 @@ mod tests {
         // Insert mix of trusted and untrusted
         for trusted in [false, true, false, true, false] {
             let follower = Keys::generate().public_key();
-            let change =
-                FollowChange::new_followed(*NOW, follower, followee).with_trusted(trusted);
+            let change = FollowChange::new_followed(*NOW, follower, followee).with_trusted(trusted);
             factory.insert(change.into());
         }
 

src/http_server.rs

@@ -4,9 +4,7 @@ mod router;
 mod trust_policy;
 
 use crate::{
-    config::Settings,
-    recommendation_queue::RecommendationQueue,
-    relay_subscriber::GetEventsOf,
+    config::Settings, recommendation_queue::RecommendationQueue, relay_subscriber::GetEventsOf,
     repo::RepoTrait,
 };
 use anyhow::{Context, Result};

src/http_server/router.rs

@@ -234,7 +234,11 @@ mod tests {
         let repo = Arc::new(MockRepo);
         let result_cache = moka::future::Cache::builder().build();
         let (queue, _receiver) = RecommendationQueue::new(repo.clone(), result_cache, 16);
-        Arc::new(AppState::new(repo, Arc::new(MockNostrClient), Arc::new(queue)))
+        Arc::new(AppState::new(
+            repo,
+            Arc::new(MockNostrClient),
+            Arc::new(queue),
+        ))
     }
 
     /// Regression test for the discovery document being served outside the