Carl/release merge cleanup (#1184)

* Remove warning. We will support these for now.

* Remove dead code in comment.

* update comments

Author: carl-adams-planet

planet/auth.py

@@ -322,11 +322,6 @@ def from_key(key: typing.Optional[str]) -> Auth:
         Parameters:
             key: Planet API key
         """
-        warnings.warn(
-            "Planet API keys will be deprecated for most use cases."
-            " Initialize an OAuth client, or create an OAuth service account."
-            " Proceeding for now.",
-            PendingDeprecationWarning)
         if not key:
             raise APIKeyAuthException('API key cannot be empty.')
 

tests/unit/test_auth.py

@@ -131,12 +131,6 @@ def test_Auth_from_env_alternate_doesnotexist(monkeypatch):
 
 
 def test_Auth_from_login(monkeypatch):
-    # auth.AuthClient has been completely removed
-    # in the conversion to planet_auth
-    # def login(*args, **kwargs):
-    #     return {'api_key': auth_data}
-    #
-    # monkeypatch.setattr(auth.AuthClient, 'login', login)
     with pytest.raises(DeprecationWarning):
         _ = auth.Auth.from_login('email', 'pw')
 

tests/unit/test_cli_session.py

@@ -73,7 +73,7 @@ async def test_CliSession_auth_valid(test_valid_secretfile):
         received_request = route.calls.last.request
         # The planet_auth library sends the api key as bearer token.
         # The older Planet SDK sent it as HTTP basic.
-        # Most Planet APIs accept either (and API keys are being deprecated.)
+        # Most Planet APIs accept either.
         # credentials = received_request.headers['authorization'].strip(
         #     'Authorization: Basic ')
         # assert base64.b64decode(credentials) == b'clisessiontest:'