Skip to content

Combine callback functions check_item_type(s) and move to specs #912

@kevinlacaille

Description

@kevinlacaille
Contributor

In planet.cli.data and planet.cli.subscriptions, we have identical pairs of callback functions: check_item_type and check_item_types, which were temporarily introduced in #905. These two functions are incredibly similar and we could probably be do with just one of them.

  1. Let's explore the possibility of removing one of the two callback functions in order to reduce complexity.
  2. Let's move these callback function(s) to planet.specs and update the Data and Subscriptions CLIs, the callback function(s) tests.

Activity

ischneider

ischneider commented on Sep 5, 2024

@ischneider
Member

Consider using a click ParamType for reuse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @ischneider@jreiberkyle@kevinlacaille

        Issue actions

          Combine callback functions check_item_type(s) and move to specs · Issue #912 · planetlabs/planet-client-python