-
Notifications
You must be signed in to change notification settings - Fork 96
Open
Labels
CLI/SDK InterfaceUpdate the CLI and SDK to the finalized interfaceUpdate the CLI and SDK to the finalized interfaceproposal
Milestone
Description
In planet.cli.data
and planet.cli.subscriptions
, we have identical pairs of callback functions: check_item_type
and check_item_types
, which were temporarily introduced in #905. These two functions are incredibly similar and we could probably be do with just one of them.
- Let's explore the possibility of removing one of the two callback functions in order to reduce complexity.
- Let's move these callback function(s) to
planet.specs
and update the Data and Subscriptions CLIs, the callback function(s) tests.
Metadata
Metadata
Assignees
Labels
CLI/SDK InterfaceUpdate the CLI and SDK to the finalized interfaceUpdate the CLI and SDK to the finalized interfaceproposal
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
ischneider commentedon Sep 5, 2024
Consider using a click ParamType for reuse