-
Notifications
You must be signed in to change notification settings - Fork 98
Subscriptions: add support for subscription's catalog source's geometry_relation #1203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the geometry_relation parameter to catalog subscriptions, allowing users to specify how subscription geometry relates to item geometry (intersects, contains, or within).
Key Changes
- Added
geometry_relationparameter to thecatalog_source()function with support for three values: "intersects", "contains", and "within" - Added
--geometry-relationCLI option to therequest-catalogcommand - Added comprehensive test coverage for the new parameter in both unit and integration tests
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| planet/subscription_request.py | Added geometry_relation parameter to catalog_source() function with type hints and documentation |
| planet/cli/subscriptions.py | Added --geometry-relation CLI option with help text and parameter forwarding |
| tests/unit/test_subscription_request.py | Added unit test for "contains" geometry relation |
| tests/integration/test_subscriptions_cli.py | Added parameterized integration test covering all three geometry relation values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Proposed Changes:
For inclusion in changelog (if applicable):
New behavior:
PR Checklist:
(Optional) @mentions for Notifications: