simplify geom inputs for tools #14
Merged
+49
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM! I reinstalled the MCP server and was able to verify the changes in Claude Desktop. 
|
wiki0831
approved these changes
Nov 12, 2025
angaither
reviewed
Nov 12, 2025
Contributor
|
any readme updates (screenshots) we want to include with this change? |
Contributor
Author
|
@angaither you're right, we should add Claude Desktop instructions. I'll include some in another commit 🙇 edit: we do already have some. Even still, a screenshot example or two might be nice |
angaither
reviewed
Nov 17, 2025
| @@ -0,0 +1,7 @@ | |||
| from typing import Any | |||
| from typing_extensions import TypedDict | |||
Contributor
There was a problem hiding this comment.
I noticed that the tool description for geometry should probably also be updated to remove the feature reference language https://github.com/planetlabs/planet-mcp/blob/main/src/planet_mcp/servers/descriptions.py#L13
* supports feature references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously had some code to simplify tool input schemas (generated from the SDK function signatures) if tool registration failed. We also now want to simplify our geojson input type hints due to inconsistent behavior using geojson inputs with Claude Desktop.
Since we have another reason to run tool functions through the
_create_param_modified_wrapperutility, I set up a list of tools to use it with (rather than relying onPydanticSchemaGenerationErrorto trigger it).