modify search to fix claude issues #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR introduces a custom data_search tool to override the SDK's default implementation, aiming to resolve issues with Claude Desktop not properly applying search filters. The new implementation explicitly constructs date range and cloud cover filters and passes them to the Planet SDK.
Key changes:
- Adds a new
search.pyserver module with a customdata_searchtool that manually constructs search filters - Removes
data_searchfrom the SDK's signature override list and adds it to the ignore list - Updates the tool description to document the new
start_dateandend_dateparameters - Updates tests to work with the new tool signature
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/planet_mcp/servers/search.py | New custom data_search implementation with explicit date and cloud cover filters |
| src/planet_mcp/servers/sdk.py | Moves data_search from signature override to ignore list to prevent conflicts |
| src/planet_mcp/servers/descriptions.py | Updates documentation to reflect new date parameter requirements |
| src/planet_mcp/servers/init.py | Registers the new search server module |
| tests/test_server.py | Updates test to use new parameters and expected output format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
angaither
force-pushed
the
ag/modify-search
branch
2 times, most recently
from
58b1c75 to
356d976
Compare
datefilter is optional, and only used if user provided
angaither
force-pushed
the
ag/modify-search
branch
from
356d976 to
c2ee833
Compare
stephenhillier
approved these changes
Dec 9, 2025
| ) | ||
| async def data_search( | ||
| item_types: list[str], | ||
| start_date: str, |
Contributor
There was a problem hiding this comment.
Suggested change
| start_date: str, | |
| start_date: str | None, |
the type hint (used for validation) still requires a value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
override the data_search sdk method to hopefully fix issues with claude desktop not using search filters correctly.
I still added the method to the 'sdk' mcp server, this is up for review if it should be it's own or not.
need someone with claude desktop to confirm fixthis has been done!