Add publish to pypi workflow #7
Merged
+106
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I see some nox sessions in the GH action workflow that don't exist in noxfile.py. Looks like we will need a script to build and then upload the package. That being said I'm not sure if there is any benefit to using nox here (other than following the pattern used in the SDK repo). Would it be simpler to just script the build/upload steps into this GH action workflow rather than use nox? cc @ischneider |
Member
|
I think the main value of nox is automation of python version testing and venv management but yeah, feels like some missing sessions... I'm not 100% versed on integration but had looked into it earlier for the SDK and recall reading this astral-sh/uv#6579 and also seeing https://github.com/dantebben/nox-uv. |
angaither
force-pushed
the
ag/add-publish-workflow
branch
from
1e4b683 to
b8d4dc5
Compare
Contributor
Author
|
added in those noxfile changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was mostly copy-pasta from https://github.com/planetlabs/planet-client-python/blob/main/.github/workflows/publish-pypi.yml
we don't have the env vars set to actually do this yet.