Merge pull request #85 from planetscale/dbussink/move-to-access-host

Move to the full access host instead of the remote addr

Author: dbussink

Diff for: planetscale/certs.go

@@ -31,7 +31,7 @@ type CertificatesService interface {
 type Cert struct {
 	ClientCert tls.Certificate
 	CACerts    []*x509.Certificate
-	RemoteAddr string
+	AccessHost string
 	Ports      RemotePorts
 }
 
@@ -103,7 +103,7 @@ func (c *certificatesService) Create(ctx context.Context, r *CreateCertificateRe
 	var cr struct {
 		Certificate      string         `json:"certificate"`
 		CertificateChain string         `json:"certificate_chain"`
-		RemoteAddr       string         `json:"remote_addr"`
+		AccessHost       string         `json:"access_host"`
 		Ports            map[string]int `json:"ports"`
 	}
 
@@ -137,7 +137,7 @@ func (c *certificatesService) Create(ctx context.Context, r *CreateCertificateRe
 	return &Cert{
 		ClientCert: clientCert,
 		CACerts:    caCerts,
-		RemoteAddr: cr.RemoteAddr,
+		AccessHost: cr.AccessHost,
 		Ports: RemotePorts{
 			Proxy: cr.Ports["proxy"],
 			MySQL: cr.Ports["mysql-tls"],

Diff for: planetscale/certs_test.go

@@ -89,20 +89,20 @@ func TestCertificates_Create(t *testing.T) {
 	pkey, err := x509.ParsePKCS1PrivateKey(block.Bytes)
 	c.Assert(err, qt.IsNil)
 
-	remoteAddr := "foo.example.com"
+	accessHost := "db.foo.example.com"
 
 	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(200)
 
 		var out = struct {
 			Certificate      string         `json:"certificate"`
 			CertificateChain string         `json:"certificate_chain"`
-			RemoteAddr       string         `json:"remote_addr"`
+			AccessHost       string         `json:"access_host"`
 			Ports            map[string]int `json:"ports"`
 		}{
 			Certificate:      testSignedPublicKey,
 			CertificateChain: testCACert,
-			RemoteAddr:       remoteAddr,
+			AccessHost:       accessHost,
 			Ports: map[string]int{
 				"mysql-tls": 3306,
 				"proxy":     3307,
@@ -126,7 +126,7 @@ func TestCertificates_Create(t *testing.T) {
 	})
 	c.Assert(err, qt.IsNil)
 
-	c.Assert(cert.RemoteAddr, qt.Equals, remoteAddr)
+	c.Assert(cert.AccessHost, qt.Equals, accessHost)
 	c.Assert(cert.CACerts, qt.HasLen, 1)
 	c.Assert(cert.ClientCert, qt.Not(qt.IsNil))
 	c.Assert(cert.ClientCert.PrivateKey, qt.Not(qt.IsNil))