Merge pull request #80 from sorcererxw/main

Fix dbutil generated key type

Author: dbussink

planetscale/dbutil/dbutil.go

@@ -41,11 +41,7 @@ type DialConfig struct {
 }
 
 func generateKey() (crypto.PrivateKey, error) {
-	pkey, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
-	if err != nil {
-		return nil, err
-	}
-	return &pkey, nil
+	return ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
 }
 
 // Dial creates a secure connection to a PlanetScale database with the given

planetscale/dbutil/dbutil_test.go

@@ -2,6 +2,7 @@ package dbutil
 
 import (
 	"context"
+	"crypto/ecdsa"
 	"crypto/tls"
 	"crypto/x509"
 	"encoding/pem"
@@ -172,3 +173,16 @@ func parseCert(pemCert string) (*x509.Certificate, error) {
 	}
 	return x509.ParseCertificate(bl.Bytes)
 }
+
+func TestGenerateKey(t *testing.T) {
+	key, err := generateKey()
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	_, ok := key.(*ecdsa.PrivateKey)
+
+	if !ok {
+		t.Fatal("generated key is not an ECDSA private key")
+	}
+}