fix: remove console.log & add tests

Author: Sobyt483

projects/lib/organization/components/organization-management/organization-management.component.spec.ts

@@ -181,4 +181,43 @@ describe('OrganizationManagementComponent', () => {
 
     expect(window.location.href).toBe('https://newOrg.test.com:8080');
   });
+
+  it('should not switch and show alert for invalid organization name', async () => {
+    const mockEnvConfig: ClientEnvironment = {
+      idpName: 'test',
+      organization: 'test',
+      oauthServerUrl: 'https://test.com',
+      clientId: 'test',
+      baseDomain: 'test.com',
+      isLocal: false,
+      developmentInstance: false,
+      authData: {
+        expires_in: '3600',
+        access_token: 'test-access-token',
+        id_token: 'test-id-token',
+      },
+    };
+    envConfigServiceMock.getEnvConfig.mockResolvedValue(mockEnvConfig);
+
+    const invalidNames = ['-abc', 'abc-', 'a.b', 'a b', ''];
+
+    for (const name of invalidNames) {
+      component.organizationToSwitch = name as any;
+      Object.defineProperty(window, 'location', {
+        value: { protocol: 'https:', port: '' },
+        writable: true,
+      });
+
+      await component.switchOrganization();
+
+      expect(luigiCoreServiceMock.showAlert).toHaveBeenCalledWith({
+        text:
+          'Organization name is not valid for subdomain usage, accrording to RFC 1034/1123.',
+        type: 'error',
+      });
+
+      expect((window.location as any).href).toBeUndefined();
+      (luigiCoreServiceMock.showAlert as jest.Mock).mockClear();
+    }
+  });
 });

projects/lib/organization/components/organization-management/organization-management.component.ts

@@ -195,9 +195,6 @@ export class OrganizationManagementComponent implements OnInit {
 
     const fullSubdomain = `${sanitizedOrg}.${baseDomain}`;
     const port = window.location.port ? `:${window.location.port}` : '';
-
-    console.log(`Switching to organization ${this.organizationToSwitch}`);
-    console.log(`Redirecting to ${protocol}//${fullSubdomain}${port}`);
     window.location.href = `${protocol}//${fullSubdomain}${port}`;
   }
 }

projects/lib/portal-options/services/header-bar-renderers/namespace-selection-renderer.service.spec.ts

@@ -172,4 +172,50 @@ describe('NamespaceSelectionRendererService', () => {
       value: { pathname: origPathname },
     });
   });
+
+  it('should skip items without name and avoid duplicates', async () => {
+    const origPathname = window.location.pathname;
+    Object.defineProperty(window, 'location', {
+      value: { pathname: '/ns1/workloads' },
+      writable: true,
+    });
+
+    const portalConfig: any = {
+      portalContext: { crdGatewayApiUrl: 'https://api.example.com/graphql' },
+    };
+
+    mockAuthService.getToken.mockReturnValue('token');
+
+    mockResourceService.list.mockReturnValue(
+      of([
+        { metadata: {} } as any,
+        { metadata: { name: 'ns1' } } as any,
+        { metadata: { name: 'ns1' } } as any,
+      ]),
+    );
+
+    const renderer = service.create(portalConfig);
+    const container = document.createElement('div');
+    const nodeItems = [
+      {
+        label: 'Workloads',
+        node: {
+          navigationContext: 'workloads',
+          context: { resourceDefinition: { scope: 'Namespaced' } },
+        },
+      },
+    ] as any;
+
+    renderer(container, nodeItems, () => {});
+
+    const cb = getChildrenByTag(container, 'ui5-combobox')[0];
+    const items = getChildrenByTag(cb, 'ui5-cb-item');
+    const texts = items.map((i) => i.getAttribute('text'));
+
+    expect(texts).toEqual(['-all-', 'ns1']);
+
+    Object.defineProperty(window, 'location', {
+      value: { pathname: origPathname },
+    });
+  });
 });