Skip to content

Commit af27036

Browse files
authored
feat: add pm prefix to all components & ignoreCustomElements fn (#163)
1 parent de3d1ae commit af27036

21 files changed

+107
-104
lines changed

angular.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
"projectType": "application",
4545
"root": "projects/wc",
4646
"sourceRoot": "projects/wc/src",
47-
"prefix": "wc",
47+
"prefix": "pm",
4848
"architect": {
4949
"build": {
5050
"builder": "ngx-build-plus:browser",

projects/wc/src/app/components/dynamic-select/dynamic-select.component.spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ describe('DynamicSelectComponent', () => {
8484

8585
fixture.detectChanges();
8686

87-
expect(component.testId()).toBe('dynamic-select-getData');
87+
expect(component.testId()).toBe('pm-dynamic-select-getData');
8888
});
8989

9090
it('should generate default testId without operation name', () => {
@@ -104,7 +104,7 @@ describe('DynamicSelectComponent', () => {
104104

105105
fixture.detectChanges();
106106

107-
expect(component.testId()).toBe('dynamic-select');
107+
expect(component.testId()).toBe('pm-dynamic-select');
108108
});
109109

110110
it('should generate optionTestId with value', () => {
@@ -125,7 +125,7 @@ describe('DynamicSelectComponent', () => {
125125
fixture.detectChanges();
126126

127127
expect(component.optionTestId('option1')).toBe(
128-
'dynamic-select-getData-option-option1',
128+
'pm-dynamic-select-getData-option-option1',
129129
);
130130
});
131131

@@ -147,7 +147,7 @@ describe('DynamicSelectComponent', () => {
147147
fixture.detectChanges();
148148

149149
expect(component.optionTestId('')).toBe(
150-
'dynamic-select-getData-option-empty',
150+
'pm-dynamic-select-getData-option-empty',
151151
);
152152
});
153153

@@ -169,7 +169,7 @@ describe('DynamicSelectComponent', () => {
169169
fixture.detectChanges();
170170

171171
expect(component.optionTestId(null)).toBe(
172-
'dynamic-select-getData-option-empty',
172+
'pm-dynamic-select-getData-option-empty',
173173
);
174174
});
175175

@@ -191,7 +191,7 @@ describe('DynamicSelectComponent', () => {
191191
fixture.detectChanges();
192192

193193
expect(component.optionTestId(undefined)).toBe(
194-
'dynamic-select-getData-option-empty',
194+
'pm-dynamic-select-getData-option-empty',
195195
);
196196
});
197197
});

projects/wc/src/app/components/dynamic-select/dynamic-select.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import { OptionComponent, SelectComponent } from '@ui5/webcomponents-ngx';
2020
import { Observable, map } from 'rxjs';
2121

2222
@Component({
23-
selector: 'dynamic-select',
23+
selector: 'pm-dynamic-select',
2424
imports: [SelectComponent, OptionComponent],
2525
templateUrl: './dynamic-select.component.html',
2626
styleUrl: './dynamic-select.component.scss',
@@ -45,7 +45,7 @@ export class DynamicSelectComponent {
4545
testId = computed(() => {
4646
const definition = this.dynamicValuesDefinition();
4747
const operation = definition.operation?.trim();
48-
return operation ? `dynamic-select-${operation}` : 'dynamic-select';
48+
return operation ? `pm-dynamic-select-${operation}` : 'pm-dynamic-select';
4949
});
5050

5151
private resourceService = inject(ResourceService);

projects/wc/src/app/components/error/error.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { ButtonConfig, ErrorConfig } from './models/error.model';
22
import {
33
ChangeDetectionStrategy,
4-
ChangeDetectorRef,
54
Component,
65
OnInit,
76
ViewEncapsulation,
@@ -20,7 +19,7 @@ import {
2019
} from '@ui5/webcomponents-ngx';
2120

2221
@Component({
23-
selector: 'app-error',
22+
selector: 'pm-error',
2423
standalone: true,
2524
templateUrl: './error.component.html',
2625
encapsulation: ViewEncapsulation.ShadowDom,

projects/wc/src/app/components/generic-ui/detail-view/detail-view.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
@for (field of viewField.group.fields; let last = $last; track field.label) {
5151
<span [class.multiline]="viewField.group.multiline ?? true">
5252
<span>{{ field.label }}: </span>
53-
<value-cell
53+
<pm-value-cell
5454
[fieldDefinition]="field"
5555
[resource]="resource"
5656
[LuigiClient]="LuigiClient()"
@@ -64,7 +64,7 @@
6464
} @else {
6565
<ui5-label [attr.test-id]="'generic-detail-view-field-' + viewField.property + '-label'">{{ viewField.label }}</ui5-label>
6666
<p [attr.test-id]="'generic-detail-view-field-' + viewField.property + '-value'">
67-
<value-cell
67+
<pm-value-cell
6868
[fieldDefinition]="viewField"
6969
[resource]="resource"
7070
[LuigiClient]="LuigiClient()"

projects/wc/src/app/components/generic-ui/detail-view/detail-view.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import {
3737
} from '@ui5/webcomponents-ngx';
3838

3939
@Component({
40-
selector: 'detail-view',
40+
selector: 'pm-detail-view',
4141
standalone: true,
4242
imports: [
4343
DynamicPageComponent,
@@ -185,4 +185,4 @@ export class DetailViewComponent {
185185

186186
return resourceDefinition;
187187
}
188-
}
188+
}

projects/wc/src/app/components/generic-ui/list-view/create-resource-modal/create-resource-modal.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
}
5454
</ui5-select>
5555
} @else if (field.dynamicValuesDefinition) {
56-
<dynamic-select
56+
<pm-dynamic-select
5757
[attr.test-id]="'create-field-' + fieldProperty"
5858
[context]="context()"
5959
[dynamicValuesDefinition]="field.dynamicValuesDefinition"

projects/wc/src/app/components/generic-ui/list-view/create-resource-modal/create-resource-modal.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ import {
3838
import { set } from 'lodash';
3939

4040
@Component({
41-
selector: 'create-resource-modal',
41+
selector: 'pm-create-resource-modal',
4242
standalone: true,
4343
imports: [
4444
ReactiveFormsModule,

projects/wc/src/app/components/generic-ui/list-view/delete-resource-confirmation-modal/delete-resource-modal.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import {
2929
} from '@ui5/webcomponents-ngx';
3030

3131
@Component({
32-
selector: 'delete-resource-modal',
32+
selector: 'pm-delete-resource-modal',
3333
standalone: true,
3434
imports: [
3535
ReactiveFormsModule,

projects/wc/src/app/components/generic-ui/list-view/list-view.component.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
<ui5-table-header-cell test-id="generic-list-header-actions" class="actions-column">Actions</ui5-table-header-cell>
4949
</ui5-table-header-row>
5050

51-
<ui5-illustrated-message test-id="generic-list-view-nodata" slot="nodata" name="NoData">
51+
<ui5-illustrated-message test-id="generic-list-view-nodata" slot="noData" name="NoData">
5252
<span slot="title">No Resources</span>
5353
<span slot="subtitle">There are currently no items to show.</span>
5454
</ui5-illustrated-message>
@@ -87,7 +87,7 @@
8787
) {
8888
<div [attr.test-id]="'generic-list-cell-' + i + '-' + column.property + '-' + field.property">
8989
<span>{{ field.label }}: </span>
90-
<value-cell
90+
<pm-value-cell
9191
[fieldDefinition]="field"
9292
[resource]="item"
9393
[LuigiClient]="LuigiClient()"
@@ -100,11 +100,11 @@
100100
</ui5-table-cell>
101101
} @else {
102102
<ui5-table-cell [attr.test-id]="'generic-list-cell-' + i + '-' + column.property">
103-
<value-cell
103+
<pm-value-cell
104104
[fieldDefinition]="column"
105105
[resource]="item"
106106
[LuigiClient]="LuigiClient()"
107-
/>
107+
/>
108108
</ui5-table-cell>
109109
}
110110
}
@@ -130,7 +130,7 @@
130130
</ui5-dynamic-page>
131131

132132
@if (hasUiCreateViewFields()) {
133-
<create-resource-modal
133+
<pm-create-resource-modal
134134
#createModal
135135
[fields]="resourceDefinition()?.ui?.createView?.fields ?? []"
136136
(resource)="create($event)"
@@ -139,7 +139,7 @@
139139
/>
140140
}
141141

142-
<delete-resource-modal
142+
<pm-delete-resource-modal
143143
#deleteModal
144144
(resource)="delete($event)"
145145
[context]="context()"

0 commit comments

Comments
 (0)