changes in lint.yml file

Author: Harsh Srivastava

.github/workflows/go-lint.yml

@@ -3,7 +3,6 @@ name: Go Lint
   push:
     branches:
       - pf9-oidc
-      - private/harsh/soc2-scan
       - private/soc2
   pull_request:
 
@@ -19,10 +18,12 @@ jobs:
       - name: Export Go Version
         run: echo "go-version=1.21" >> $GITHUB_OUTPUT
 
-  golangci-lint:
+  golangci-lint-and-pr:
     name: GolangCI Lint & Auto PR
     needs: setup
     runs-on: ubuntu-latest
+    outputs:
+      golangci-issues-found: ${{ steps.scan.outputs.golangci_issues_found }}
     permissions:
       contents: write
       pull-requests: write
@@ -42,34 +43,51 @@ jobs:
             | sh -s -- -b $(go env GOPATH)/bin v1.59.0
           echo "$(go env GOPATH)/bin" >> $GITHUB_PATH
 
-      - name: Run golangci-lint
-        id: golangci
+      - name: Sanitize branch name
+        run: echo "SAFE_REF_NAME=${GITHUB_REF_NAME//\//-}" >> $GITHUB_ENV
+
+      - name: Run GolangCI Lint Scan
+        id: scan
         run: |
-          echo "🔍 Running golangci-lint..."
-          golangci-lint run ./... > golangci_output.txt || true
-          cat golangci_output.txt
-          if [ -s golangci_output.txt ]; then
-            echo "lint_issues=true" >> "$GITHUB_OUTPUT"
+          echo "Running GolangCI lint scan..."
+          mkdir -p tmp
+          golangci-lint run ./... --out-format=json > tmp/golangci_output.json || true
+          echo -e "\nHuman-readable GolangCI output:\n"
+          golangci-lint run ./... || true
+          cat tmp/golangci_output.json || echo "{}"
+          
+          issue_count=$(jq '.Issues | length' tmp/golangci_output.json 2>/dev/null || echo 0)
+          
+          if [[ "$issue_count" -gt 0 ]]; then
+            echo "golangci_issues_found=true" >> "$GITHUB_OUTPUT"
           else
-            echo "lint_issues=false" >> "$GITHUB_OUTPUT"
+            echo "golangci_issues_found=false" >> "$GITHUB_OUTPUT"
           fi
 
-      - name: Create PR if Issues Found
-        if: ${{ steps.golangci.outputs.lint_issues == 'true' }}
-        uses: peter-evans/create-pull-request@v5
+      - name: Upload GolangCI Report
+        uses: actions/upload-artifact@v4
         with:
-          commit-message: 'chore: fix golangci-lint issues'
-          title: 'chore: GolangCI Lint Issues Found'
-          body: |
-            ## ⚠️ GolangCI Lint Issues Found
-            See `golangci_output.txt` for full details.
-          branch: auto/golangci-lint-issues
-          base: pf9-oidc
-          add-paths: |
-            golangci_output.txt
+          name: golangci-json-${{ env.SAFE_REF_NAME }}
+          path: tmp/golangci_output.json
 
-      - name: Fail job if issues found
-        if: ${{ steps.golangci.outputs.lint_issues == 'true' }}
+      - name: Generate PR Body (if issues found)
+        if: ${{ steps.scan.outputs.golangci_issues_found == 'true' }}
         run: |
-          echo "❌ GolangCI lint issues found — failing job."
-          exit 1
+          echo "# GolangCI Lint Report for branch \`${GITHUB_REF_NAME}\`" > tmp/pr-body.md
+          jq -r '.Issues[] | "* File: \(.Pos.Filename)\n  • Line: \(.Pos.Line)\n  • Column: \(.Pos.Column)\n  • Linter: \(.FromLinter)\n  • Message: \(.Text)\n"' \
+            tmp/golangci_output.json >> tmp/pr-body.md
+
+      - name: Create Pull Request (if issues found)
+        if: ${{ github.event_name == 'push' && steps.scan.outputs.golangci_issues_found == 'true' }}
+        uses: peter-evans/create-pull-request@v5
+        with:
+          commit-message: 'chore: GolangCI lint issues detected'
+          title: 'GolangCI Lint Report for branch ${{ github.ref_name }}'
+          body-path: tmp/pr-body.md
+          branch: auto/golangci-lint/${{ env.SAFE_REF_NAME }}
+          base: ${{ github.ref_name }}
+          delete-branch: true
+
+      - name: Fail Job If Issues Found
+        if: ${{ steps.scan.outputs.golangci_issues_found == 'true' }}
+        run: exit 1

.github/workflows/security-scan.yml

@@ -4,7 +4,6 @@ on:
   push:
     branches:
       - pf9-oidc
-      - private/harsh/soc2-scan
       - private/soc2
   pull_request: