Skip to content

Enable consistent-return rule #9

@willeastcott

Description

@willeastcott

This would address these issues in the engine codebase:

C:\dev\enginelgtm\rollup.config.js
  35:13  error  Method 'transform' expected no return value  consistent-return
  83:13  error  Method 'transform' expected no return value  consistent-return

C:\dev\enginelgtm\src\anim\controller\anim-controller.js
  487:9  error  Method 'removeNodeAnimations' expected no return value  consistent-return

C:\dev\enginelgtm\src\anim\controller\anim-state.js
  57:5  error  Expected to return a value at the end of method '_createTree'  consistent-return

C:\dev\enginelgtm\src\framework\application.js
  1423:9  error  Method 'resizeCanvas' expected no return value  consistent-return

C:\dev\enginelgtm\src\framework\components\anim\component.js
  589:5  error  Expected to return a value at the end of method 'getParameterValue'  consistent-return

C:\dev\enginelgtm\src\framework\components\collision\system.js
  416:13  error  Method 'createPhysicalShape' expected no return value  consistent-return

C:\dev\enginelgtm\src\framework\components\element\component.js
  872:5  error  Expected to return a value at the end of method '_setPosition'  consistent-return
  911:5  error  Expected to return a value at the end of method '_sync'         consistent-return

C:\dev\enginelgtm\src\framework\components\script-legacy\component.js
  12:5  error  Expected to return a value at the end of method 'send'  consistent-return

C:\dev\enginelgtm\src\framework\components\scroll-view\component.js
  438:5  error  Expected to return a value at the end of method '_getScrollingEnabled'     consistent-return
  448:5  error  Expected to return a value at the end of method '_getScrollbarVisibility'  consistent-return

C:\dev\enginelgtm\src\framework\components\sound\slot.js
  146:9  error  Method 'play' expected no return value  consistent-return

C:\dev\enginelgtm\src\graphics\program-lib\programs\standard.js
  91:22  error  Expected to return a value at the end of method '_correctChannel'  consistent-return

C:\dev\enginelgtm\src\graphics\reproject-texture.js
  39:40  error  Expected to return a value at the end of arrow function  consistent-return

C:\dev\enginelgtm\src\graphics\texture.js
  1012:9  error  Method 'getDds' expected no return value  consistent-return

C:\dev\enginelgtm\src\resources\basis-worker.js
   60:63  error  Expected to return a value at the end of arrow function  consistent-return
  159:61  error  Expected to return a value at the end of arrow function  consistent-return

C:\dev\enginelgtm\src\resources\font.js
   69:81  error  Expected to return a value at the end of function  consistent-return
  105:21  error  Function expected no return value                  consistent-return

C:\dev\enginelgtm\src\resources\loader.js
  263:5  error  Expected to return a value at the end of method 'getFromCache'  consistent-return

C:\dev\enginelgtm\src\resources\parser\texture\ktx2.js
  57:5  error  Expected to return a value at the end of method 'parse'  consistent-return

C:\dev\enginelgtm\src\resources\texture-atlas.js
  53:5  error  Expected to return a value at the end of method 'load'  consistent-return

C:\dev\enginelgtm\src\resources\texture.js
  251:9  error  Method 'open' expected no return value  consistent-return

C:\dev\enginelgtm\src\scene\batching\batch-manager.js
  152:9  error  Method 'addGroup' expected no return value  consistent-return

C:\dev\enginelgtm\src\scene\materials\standard-material-options-builder.js
  277:5  error  Expected to return a value at the end of method '_updateTexOptions'  consistent-return

C:\dev\enginelgtm\src\vr\vr-display.js
  341:5  error  Expected to return a value at the end of method 'getFrameData'  consistent-return

✖ 27 problems (27 errors, 0 warnings)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions