fix(no-unsafe-references): Ignore TypeScript type references

Fixes #214

Author: mskelton

src/rules/no-unsafe-references.ts

@@ -1,6 +1,11 @@
 import { AST, Rule, Scope } from 'eslint';
 import * as ESTree from 'estree';
-import { getStringValue, isFunction, isPageMethod } from '../utils/ast';
+import {
+  getParent,
+  getStringValue,
+  isFunction,
+  isPageMethod,
+} from '../utils/ast';
 import { truthy } from '../utils/misc';
 
 /** Collect all variable references in the parent scopes recursively. */
@@ -101,6 +106,10 @@ export default {
         // If a variable is used in the function, but not declared in the parent,
         // then it's likely a global variable such as `Promise` or `console`.
         through
+          .filter((ref) => {
+            const parent = getParent(ref.identifier);
+            return (parent?.type as string) !== 'TSTypeReference';
+          })
           .filter((ref) => allRefs.has(ref.identifier.name))
           .forEach((ref, i, arr) => {
             const descriptor: Rule.ReportDescriptor = {

src/utils/ast.ts

@@ -101,6 +101,10 @@ export function isDescribeCall(node: ESTree.Node): boolean {
     : false;
 }
 
+export function getParent(node: ESTree.Node): ESTree.Node | undefined {
+  return (node as any).parent;
+}
+
 export function findParent<T extends ESTree.Node['type']>(
   node: NodeWithParent,
   type: T,

test/spec/no-unsafe-references.spec.ts

@@ -316,5 +316,39 @@ runRuleTester('no-unsafe-references', rule, {
       `,
       name: 'Multi-level scopes',
     },
+    // TypeScript
+    {
+      code: dedent`
+        type X = number;
+        const result = await page.evaluate(() => {
+          const x = 10 as X;
+          return Promise.resolve(x);
+        });
+      `,
+      name: 'TypeScript - variable assignment of type',
+      parser: require.resolve('@typescript-eslint/parser'),
+    },
+    {
+      code: dedent`
+        type X = number;
+        const result = await page.evaluate(() => {
+          const foo = (bar: X) => bar;
+          return Promise.resolve(foo(10));
+        });
+      `,
+      name: 'TypeScript - parameter type',
+      parser: require.resolve('@typescript-eslint/parser'),
+    },
+    {
+      code: dedent`
+        type X = number;
+        const result = await page.evaluate(() => {
+          const x: X = 10;
+          return Promise.resolve(x);
+        });
+      `,
+      name: 'TypeScript - casting',
+      parser: require.resolve('@typescript-eslint/parser'),
+    },
   ],
 });