Skip to content

Commit 6baec3a

Browse files
authored
fix: Remove no-slowed-test from recommended list (#348)
* fix: Add no-slowed-test to sharedConfig * fix: remove no-slowed-test from recommended list
1 parent 956fe62 commit 6baec3a

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ CLI option\
139139
| [no-raw-locators](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-raw-locators.md) | Disallow using raw locators | | | |
140140
| [no-restricted-matchers](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-restricted-matchers.md) | Disallow specific matchers & modifiers | | | |
141141
| [no-skipped-test](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-skipped-test.md) | Disallow usage of the `.skip` annotation || | 💡 |
142-
| [no-slowed-test](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-slowed-test.md) | Disallow usage of the `.slow` annotation | | | 💡 |
142+
| [no-slowed-test](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-slowed-test.md) | Disallow usage of the `.slow` annotation | | | 💡 |
143143
| [no-standalone-expect](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-standalone-expect.md) | Disallow using expect outside of `test` blocks || | |
144144
| [no-unsafe-references](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-unsafe-references.md) | Prevent unsafe variable references in `page.evaluate()` || 🔧 | |
145145
| [no-useless-await](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-useless-await.md) | Disallow unnecessary `await`s for Playwright methods || 🔧 | |

src/index.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import noPagePause from './rules/no-page-pause.js'
2020
import noRawLocators from './rules/no-raw-locators.js'
2121
import noRestrictedMatchers from './rules/no-restricted-matchers.js'
2222
import noSkippedTest from './rules/no-skipped-test.js'
23-
import noSlowedTests from './rules/no-slowed-test.js'
23+
import noSlowedTest from './rules/no-slowed-test.js'
2424
import noStandaloneExpect from './rules/no-standalone-expect.js'
2525
import noUnsafeReferences from './rules/no-unsafe-references.js'
2626
import noUselessAwait from './rules/no-useless-await.js'
@@ -73,7 +73,7 @@ const index = {
7373
'no-raw-locators': noRawLocators,
7474
'no-restricted-matchers': noRestrictedMatchers,
7575
'no-skipped-test': noSkippedTest,
76-
'no-slowed-test': noSlowedTests,
76+
'no-slowed-test': noSlowedTest,
7777
'no-standalone-expect': noStandaloneExpect,
7878
'no-unsafe-references': noUnsafeReferences,
7979
'no-useless-await': noUselessAwait,

src/rules/no-slowed-test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export default createRule({
5252
docs: {
5353
category: 'Best Practices',
5454
description: 'Prevent usage of the `.slow()` slow test annotation.',
55-
recommended: true,
55+
recommended: false,
5656
url: 'https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-slowed-test.md',
5757
},
5858
hasSuggestions: true,

0 commit comments

Comments
 (0)