Open
Description
Hi, these rules have an allowConditional
option
- https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-slowed-test.md
- https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-skipped-test.md
I interpreted the documentation to mean that this:
{
"playwright/no-skipped-test": [
"error",
{
"allowConditional": true
}
]
}
makes .skip()
disallowed unless a condition is provided, eg
test('foo', ({ browserName }) => {
test.skip(browserName === 'firefox', 'Still working on it') // pass
})
test('foo', ({ browserName }) => {
test.skip() // fail
})
However, the behavior I am seeing is
test('foo', ({ browserName }) => {
test.skip(browserName === 'firefox', 'Still working on it') // pass
})
test('foo', ({ browserName }) => {
test.skip() // pass
})
Using 2.2.0
. Do I misunderstand the docs? As in, does "allowConditional": true
just mean that chaining .skip
in the original test()
call is prohibited, but any variation of test.skip()
within the body of the test is allowed?
Metadata
Metadata
Assignees
Labels
No labels