From fd12046be01c0e5b437e3eead0095aff40f30e9a Mon Sep 17 00:00:00 2001
From: Manzoor Wani <manzoorwani.jk@gmail.com>
Date: Thu, 28 Nov 2024 16:59:54 +0530
Subject: [PATCH 1/2] fix(expect-expert): report on test function identifier
 rather than body

---
 src/rules/expect-expect.test.ts | 10 +++++-----
 src/rules/expect-expect.ts      |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/rules/expect-expect.test.ts b/src/rules/expect-expect.test.ts
index f146ab0..2115bd8 100644
--- a/src/rules/expect-expect.test.ts
+++ b/src/rules/expect-expect.test.ts
@@ -5,11 +5,11 @@ runRuleTester('expect-expect', rule, {
   invalid: [
     {
       code: 'test("should fail", () => {});',
-      errors: [{ messageId: 'noAssertions' }],
+      errors: [{ messageId: 'noAssertions', type: 'Identifier', }],
     },
     {
       code: 'test.skip("should fail", () => {});',
-      errors: [{ messageId: 'noAssertions' }],
+      errors: [{ messageId: 'noAssertions', type: 'MemberExpression' }],
     },
     {
       code: javascript`
@@ -17,7 +17,7 @@ runRuleTester('expect-expect', rule, {
           await assertCustomCondition(page)
         })
       `,
-      errors: [{ messageId: 'noAssertions' }],
+      errors: [{ messageId: 'noAssertions', type: 'Identifier' }],
     },
     {
       code: javascript`
@@ -25,13 +25,13 @@ runRuleTester('expect-expect', rule, {
           await assertCustomCondition(page)
         })
       `,
-      errors: [{ messageId: 'noAssertions' }],
+      errors: [{ messageId: 'noAssertions', type: 'Identifier' }],
       name: 'Custom assert function',
       options: [{ assertFunctionNames: ['wayComplexCustomCondition'] }],
     },
     {
       code: 'it("should pass", () => hi(true).toBeDefined())',
-      errors: [{ messageId: 'noAssertions' }],
+      errors: [{ messageId: 'noAssertions', type: 'Identifier' }],
       name: 'Global aliases',
       settings: {
         playwright: {
diff --git a/src/rules/expect-expect.ts b/src/rules/expect-expect.ts
index 89b7efa..481cae4 100644
--- a/src/rules/expect-expect.ts
+++ b/src/rules/expect-expect.ts
@@ -40,7 +40,7 @@ export default createRule({
       },
       'Program:exit'() {
         unchecked.forEach((node) => {
-          context.report({ messageId: 'noAssertions', node })
+          context.report({ messageId: 'noAssertions', node: node.callee })
         })
       },
     }

From be2d567c155ccb35cb11f288757aa4855c63e277 Mon Sep 17 00:00:00 2001
From: Manzoor Wani <manzoorwani.jk@gmail.com>
Date: Thu, 28 Nov 2024 19:06:59 +0530
Subject: [PATCH 2/2] Prettier

---
 src/rules/expect-expect.test.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/rules/expect-expect.test.ts b/src/rules/expect-expect.test.ts
index 2115bd8..54c8249 100644
--- a/src/rules/expect-expect.test.ts
+++ b/src/rules/expect-expect.test.ts
@@ -5,7 +5,7 @@ runRuleTester('expect-expect', rule, {
   invalid: [
     {
       code: 'test("should fail", () => {});',
-      errors: [{ messageId: 'noAssertions', type: 'Identifier', }],
+      errors: [{ messageId: 'noAssertions', type: 'Identifier' }],
     },
     {
       code: 'test.skip("should fail", () => {});',