Skip to content

Commit 1a46c6f

Browse files
authored
Merge pull request #77 from pleonex/feature/release-dep
🐛 Missing dependency to restore GitReleaseManager when uploading binaries
2 parents d24f3f8 + 06e14d7 commit 1a46c6f

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

docs/articles/getting-started/setup-checklist.md

+2
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ following [project template](https://github.com/pleonex/template-csharp).
8585
4. Review `build.yml` to remove / add OS platforms to run build and tests.
8686
5. Enable GitHub Pages in the repository settings
8787
1. Select GitHub Actions as the source.
88+
2. From _Environments_, select `github-pages`. Under _Deployment branches and
89+
tags_ add a new rule to allow publishing docs from the tags `v*`.
8890

8991
## Collaboration files
9092

docs/articles/recipe/github.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ the current version (if any) into `ChangelogNextFile`.
4646
- Task name: `PleOps.Recipe.GitHub.UploadReleaseBinaries`
4747
- Type:
4848
[`UploadReleaseBinaries`](xref:Cake.Frosting.PleOps.Recipe.GitHub.UploadReleaseBinariesTask)
49-
- Depends on: none
49+
- Depends on: [`RestoreTools`](./common.md#restore-tools)
5050
- Condition: build type is `Stable` and `GitHubToken` is not empty.
5151
- Build context: `PleOpsBuildContext`
5252
- Uses:

src/Cake.Frosting.PleOps.Recipe/GitHub/UploadReleaseBinariesTask.cs

+1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ namespace Cake.Frosting.PleOps.Recipe.GitHub;
3030
/// This action only runs for stable builds if the GitHub token is present.
3131
/// </remarks>
3232
[TaskName("PleOps.Recipe.GitHub.UploadReleaseBinaries")]
33+
[IsDependentOn(typeof(Common.RestoreToolsTask))]
3334
public class UploadReleaseBinariesTask : FrostingTask<PleOpsBuildContext>
3435
{
3536
/// <inheritdoc />

0 commit comments

Comments
 (0)