Skip to content

Commit 5e30786

Browse files
authored
Merge pull request #80 from pleonex/feature/docs-fixes
📚 Add missing steps to setup GitHub Pages and other small doc fixes
2 parents 0b5849b + 3587383 commit 5e30786

File tree

3 files changed

+21
-9
lines changed

3 files changed

+21
-9
lines changed

docs/articles/getting-started/setup-checklist.md

+6-1
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,9 @@ following [project template](https://github.com/pleonex/template-csharp).
8787
1. Select GitHub Actions as the source.
8888
2. From _Environments_, select `github-pages`. Under _Deployment branches and
8989
tags_ add a new rule to allow publishing docs from the tags `v*`.
90+
3. Enable write permissions to publish GitHub Pages. From Actions, "General",
91+
go to "Workflow permissions" and ensure it's set to "Read and write
92+
permissions".
9093

9194
## Collaboration files
9295

@@ -99,7 +102,9 @@ following [project template](https://github.com/pleonex/template-csharp).
99102
explain how to create issues and pull requests.
100103
2. `CODE_OF_CONDUCT.md`: GitHub can help to create it.
101104
3. Create IDE support files:
102-
1. [`.editorconfig`](https://github.com/pleonex/template-csharp/blob/main/.editorconfig):
105+
1. [`.editorconfig`](https://github.com/pleonex/template-csharp/blob/main/.editorconfig)
106+
and
107+
[`.prettierrc.yaml`](https://github.com/pleonex/template-csharp/blob/main/.prettierrc.yaml):
103108
code styles and code warnings.
104109
2. [`.vscode/`](https://github.com/pleonex/template-csharp/tree/main/.vscode):
105110
VS Code support to build, run and debug the project.

docs/articles/getting-started/setup-template.md

+4-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ structure. Then follow this checklist to adapt the template to your project.
1313

1414
1. Rename, edit, remove the project folders inside `src/` and the solution file.
1515
2. Edit the project name and URL in `src/Directory.Build.props`
16-
3. Add, remove, update dependencies in `src/Directory.Build.targets`
16+
3. Add, remove, update dependencies in `src/Directory.Packages.props`
1717
4. Update the `.csproj` files with the correct dependencies.
1818
5. Update `build/orchestrator/Program.cs` with the list of publishable .NET
1919
projects in `ApplicationProjects`.
@@ -37,7 +37,9 @@ structure. Then follow this checklist to adapt the template to your project.
3737
`nuget_preview_token` or `azure_nuget_token`
3838
3. Review `build.yml` to remove / add OS platforms to run build and tests.
3939
4. Enable GitHub Pages in the repository settings
40-
1. Select GitHub Actions as the source.
40+
1. Pages -> Select GitHub Actions as the source.
41+
2. Environments -> github-pages -> Add new rule for tags `v*`
42+
3. Actions -> General -> Workflow permissions -> Read and write permissions
4143

4244
## Collaboration files
4345

docs/articles/getting-started/tutorial-ci.md

+11-6
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,14 @@ In order to run this workflow you will need to configure a couple of things:
6262
and pass it to `azure_nuget_token` input. Define also `azure_nuget_feed`.
6363
- **Enable GitHub pages**: if you want to publish your documentation via GitHub
6464
pages, you need to enable in your project settings:
65-
1. Go to _Settings_ > _Pages_
66-
2. In _Source_ select _GitHub Actions_
67-
3. Optionally set a domain and enforce HTTPS.
68-
4. Go to _Environments_ and select `github-pages`
69-
5. Under _Deployment branches and tags_ add a new rule to allow publishing
70-
docs from the tags `v*`.
65+
- Enable publishing from a GitHub Action:
66+
1. Go to _Settings_ > _Pages_
67+
2. In _Source_ select _GitHub Actions_
68+
3. Optionally set a domain and enforce HTTPS.
69+
- Allow to publish documentation from a tag (release builds):
70+
1. Go to _Environments_ and select `github-pages`
71+
2. Under _Deployment branches and tags_ add a new rule to allow publishing
72+
docs from the tags `v*`.
73+
- Give write permissions to `GITHUB_TOKEN`:
74+
1. Go to _Actions_ > _General_
75+
2. Under _Workflow permissions_ select _Read and write permissions_.

0 commit comments

Comments
 (0)