Merge pull request #257 from plivo/SMS-6606

SMS-6606: OTP optional param added for create and validate session

Author: kanishka2104

CHANGELOG.md

@@ -1,4 +1,7 @@
 # Change Log
+## [4.48.0](https://github.com/plivo/plivo-python/tree/v4.48.0) (2024-02-12)
+**Custom Verify OTP - Added new optional param 'otp' for Create Session and made 'otp' param optional for Validate Session**
+
 ## [4.47.2](https://github.com/plivo/plivo-python/tree/v4.47.2) (2024-01-25)
 **Added new params 'create_mpc_with_single_participant' for Add Participant API of MPC**
 

plivo/resources/verify.py

@@ -22,12 +22,14 @@ class Sessions(PlivoResourceInterface):
 
     @validate_args(
         app_uuid=[optional(of_type(six.text_type))],
+        otp=[optional(of_type(six.text_type))],
         recipient=[required(is_phonenumber())],
         channel=[optional(all_of(of_type(six.text_type), is_in(('sms', 'voice'))))],
         url=[optional(is_url())],
         method=[optional(of_type(six.text_type))])
     def create(self,
                app_uuid=None,
+               otp=None,
                recipient=None,
                channel=None,
                url=None,
@@ -91,8 +93,6 @@ def list(self,
         session_uuid=[of_type(six.text_type)]
     )
     def validate(self, session_uuid, otp=None):
-        if otp is None:
-            raise ValidationError('otp is required')
         return self.client.request('POST', ('Verify', 'Session', session_uuid),
                                    to_param_dict(self.validate, locals()))
 

plivo/version.py

@@ -1,2 +1,2 @@
 # -*- coding: utf-8 -*-
-__version__ = '4.47.2'
+__version__ = '4.48.0'

setup.py

@@ -10,7 +10,7 @@
 
 setup(
     name='plivo',
-    version='4.47.2',
+    version='4.48.0',
     description='A Python SDK to make voice calls & send SMS using Plivo and to generate Plivo XML',
     long_description=long_description,
     url='https://github.com/plivo/plivo-python',

tests/resources/test_verify.py

@@ -61,9 +61,3 @@ def test_validate(self):
         self.assertEqual(test_session.message,
                          expected_response['message'])
 
-    def test_validate_without_otp(self):
-        self.assertRaises(
-            exceptions.ValidationError,
-            self.client.verify_session.validate,
-            session_uuid='1234567'
-        )